Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[device/accton]: Update Accton-AS7326-56X #2482

Merged
merged 1 commit into from
Mar 23, 2019

Conversation

pollyhsu2git
Copy link
Contributor

@pollyhsu2git pollyhsu2git commented Jan 25, 2019

  • Update Accton-AS7326-56X to adapt xxx.config.bcm based on the latest update of Device-Specific File Directory Structure
  • Update Accton-AS7326-56X upon the port link / led test / PING out / SCP upon self-bringing up the new SAI version, 3.4.0.2

Signed-off-by: polly_hsu@edge-core.com

- What I did
Update Accton-AS7326-56X upon the port link / led test / PING out / SCP upon self-bringing up the new SAI version, 3.4.0.2

- How I did it

  1. Update Accton-AS7326-56X to adapt xxx.config.bcm based on the latest update of Device-Specific File Directory Structure the SONiC Porting Guide.
  2. Update Accton-AS7326-56X against the latest update of the SONiC Porting Guide (https://github.com/Azure/SONiC/wiki/Porting-Guide).

- How to verify it

  1. Target-verified the port mapping of 48x25G+8x100G as expected.
  2. Target-verified the port link of -48x25G+8x100G as expected.
  3. Target-verified the port led of -48x25G+8x100G as expected, however, we off-loaded the TD3 LED BINs to our self-brought up SAI libraries due to SONiC NOT supporting them currently.
  4. Ran config_checker passed on our config.bcm, however, we off-loaded the needed TD3 SDK config setting to our self-brought up SAI libraries due to SONiC NOT supporting them currently (config_check ERRORs them).
    [-] help_cli_enable=1
    [-] ifp_inports_support_enable=1
    [-] memlist_enable=1
    [-] port_flex_enable=1
    [-] reglist_enable=1

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@lguohan
Copy link
Collaborator

lguohan commented Jan 25, 2019

except for ifp_inports_support_enable, all others can be added to permitted list. what is the use case for ifp_inports_support_enable? We can help to white list it.

@lguohan
Copy link
Collaborator

lguohan commented Jan 25, 2019

what is the problem of port led? Can you describe the problem what is not supported by current SAI?

@pollyhsu2git
Copy link
Contributor Author

@lguohan
For ifp_inports_support_enable, brcm_sai_dm_init needs to set up the SDK config, ifp_inports_support_enable=1 based on the TD3 model brought-up tests.

Jan 1 00:21:02.890487 sonic ERR syncd/syncd: _brcm_sai_create_trap_resource:3983 field group create failed with error Feature unavailable (0xfffffff0).
Jan 1 00:21:02.890487 sonic CRIT syncd/syncd: _brcm_sai_dm_init:8597 initializing hostif state failed with error -2.
Jan 1 00:21:02.890487 sonic CRIT syncd/syncd: brcm_sai_create_switch:449 initializing modules data failed with error -2.
Jan 1 00:21:02.890487 sonic ERR syncd/syncd: :- processEvent: attr: SAI_SWITCH_ATTR_INIT_SWITCH: true
Jan 1 00:21:02.890487 sonic ERR syncd/syncd: :- processEvent: attr: SAI_SWITCH_ATTR_FDB_EVENT_NOTIFY: 0x421130
Jan 1 00:21:02.890487 sonic ERR syncd/syncd: :- processEvent: attr: SAI_SWITCH_ATTR_PORT_STATE_CHANGE_NOTIFY: 0x421140
Jan 1 00:21:02.890487 sonic ERR syncd/syncd: :- processEvent: attr: SAI_SWITCH_ATTR_SWITCH_SHUTDOWN_REQUEST_NOTIFY: 0x421150
Jan 1 00:21:02.890487 sonic ERR syncd/syncd: :- processEvent: attr: SAI_SWITCH_ATTR_SRC_MAC_ADDRESS: 3C:2C:99:CF:72:20
Jan 1 00:21:02.890531 sonic ERR syncd/syncd: :- processEvent: failed to execute api: create, key: SAI_OBJECT_TYPE_SWITCH:oid:0x21000000000000, status: SAI_STATUS_NOT_SUPPORTED

@pollyhsu2git
Copy link
Contributor Author

@lguohan
For the TD3 model,

  • It needs the CANCUN firmware to do the initialization. The CACUN firmware is not supported on your SAI. We've reported it via Is the branch, 201811 (Broadcom SAI 3.3 GA release) supporting the Broadcom TD3 chip yet? #2370 wit the detailed debug messages
  • For the latest Broadcom chip design, the LED work is off-loaded to the LED micro processor with its LED BIN firmware (Binary). We've see another vendor trying to PR, but rejected due to its binary format. Plus, the LED BIN firmware (Binary) MUST be executed in the specific step within its CANCUN firmware initialization.

@lguohan lguohan merged commit b36b84f into sonic-net:master Mar 23, 2019
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Oct 25, 2022
…rm-common] advance submodule head

linkmgrd:
* d7d6635 2022-10-21 | Fix link prober state event report twice issue (sonic-net#149) (HEAD -> 202205) [Longxiang Lyu]
* 0ef3296 2022-10-21 | [active-active] Add support to send/handle mux probe request (sonic-net#147) [Longxiang Lyu]
* a66fa34 2022-10-17 | [active-active] Fix config reload (sonic-net#145) [Longxiang Lyu]
* 7e1c820 2022-10-11 | [Active-Standby] avoid posting mux metrics event when receiving unsolicited mux state notification  (sonic-net#142) [Jing Zhang]
* 237cfd2 2022-10-07 | [Active-Active] Update default route shutdown heartbeat logic (sonic-net#141) [Jing Zhang]

utilities:
* 415d30e 2022-10-23 | [techsupport] Adding FRR EVPN dumps (sonic-net#2442) (HEAD -> 202205) [Sudharsan Dhamal Gopalarathnam]
* b3ffe45 2022-10-21 | [show][muxcable] add support for show mux firmware version all (sonic-net#2441) [vdahiya12]
* 7d68534 2022-10-19 | [app_ext] [auto-ts] Add available_mem_threshold option (sonic-net#2423) [Vivek]
* 52b9c16 2022-10-07 | [muxcable][config] add CLI support for mux mode detach (sonic-net#2425) [Jing Zhang]
* 14646ff 2022-10-10 | [show priority-group drop counters] Remove backup with cached PG drop counters after 'config reload' (sonic-net#2386) [Andriy Yurkiv]
* dffcc53 2022-10-11 | Add a subcommand to display a hexdump of transceiver EEPROM page (sonic-net#2379) [mihirpat1]
* 86175c2 2022-10-17 | [chassis]Add fabric counter cli commands (sonic-net#1860) [Maxime Lorrillere]

swss:
* 6fe0afd 2022-10-25 | [portsorch] remove port OID from saiOidToAlias map on port deletion (sonic-net#2483) (HEAD -> 202205, github/202205) [Stepan Blyshchak]
* 7290d66 2022-10-07 | [vlanmgr] Disable `arp_evict_nocarrier` for vlan host intf (sonic-net#2469) [Longxiang Lyu]
* d074001 2022-10-05 | [chassis][voq]Collect counters for fabric links (sonic-net#1944) [Maxime Lorrillere]
* 3a0353a 2022-10-18 | [counters][202205] Improve performance by polling only configured ports buffer queue/pg counters (sonic-net#2474) [Vadym Hlushko]
* 2feb39d 2022-10-14 | [202205] [crm] Fix issue with continues EXCEEDED and CLEAR logs for ACL group/table counters (sonic-net#2482) [Volodymyr Samotiy]

sairedis:
* 326b630 2022-10-21 | [gbsyncd] Add asic db prefix for channel NOTIFICATIONS (sonic-net#1129) (HEAD -> 202205) [Junhua Zhai]

platform-daemon:
* 6dbda9b 2022-10-25 | [ycabled] fix no port/state returned by grpc server (sonic-net#308) (HEAD -> 202205) [vdahiya12]
* 3d1228a 2022-10-20 | Fix xcvrd to support 400G ZR optic (sonic-net#293) [Bohan Yang]

platform-common:
* c04d710 2022-09-29 | Read CMIS data path state duration (sonic-net#312) (HEAD -> 202205) [Bohan Yang]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca added a commit that referenced this pull request Oct 27, 2022
…rm-common] advance submodule head (#12492)

linkmgrd:
* d7d6635 2022-10-21 | Fix link prober state event report twice issue (#149) (HEAD -> 202205) [Longxiang Lyu]
* 0ef3296 2022-10-21 | [active-active] Add support to send/handle mux probe request (#147) [Longxiang Lyu]
* a66fa34 2022-10-17 | [active-active] Fix config reload (#145) [Longxiang Lyu]
* 7e1c820 2022-10-11 | [Active-Standby] avoid posting mux metrics event when receiving unsolicited mux state notification  (#142) [Jing Zhang]
* 237cfd2 2022-10-07 | [Active-Active] Update default route shutdown heartbeat logic (#141) [Jing Zhang]

utilities:
* 415d30e 2022-10-23 | [techsupport] Adding FRR EVPN dumps (#2442) (HEAD -> 202205) [Sudharsan Dhamal Gopalarathnam]
* b3ffe45 2022-10-21 | [show][muxcable] add support for show mux firmware version all (#2441) [vdahiya12]
* 7d68534 2022-10-19 | [app_ext] [auto-ts] Add available_mem_threshold option (#2423) [Vivek]
* 52b9c16 2022-10-07 | [muxcable][config] add CLI support for mux mode detach (#2425) [Jing Zhang]
* 14646ff 2022-10-10 | [show priority-group drop counters] Remove backup with cached PG drop counters after 'config reload' (#2386) [Andriy Yurkiv]
* dffcc53 2022-10-11 | Add a subcommand to display a hexdump of transceiver EEPROM page (#2379) [mihirpat1]
* 86175c2 2022-10-17 | [chassis]Add fabric counter cli commands (#1860) [Maxime Lorrillere]

swss:
* 6fe0afd 2022-10-25 | [portsorch] remove port OID from saiOidToAlias map on port deletion (#2483) (HEAD -> 202205, github/202205) [Stepan Blyshchak]
* 7290d66 2022-10-07 | [vlanmgr] Disable `arp_evict_nocarrier` for vlan host intf (#2469) [Longxiang Lyu]
* d074001 2022-10-05 | [chassis][voq]Collect counters for fabric links (#1944) [Maxime Lorrillere]
* 3a0353a 2022-10-18 | [counters][202205] Improve performance by polling only configured ports buffer queue/pg counters (#2474) [Vadym Hlushko]
* 2feb39d 2022-10-14 | [202205] [crm] Fix issue with continues EXCEEDED and CLEAR logs for ACL group/table counters (#2482) [Volodymyr Samotiy]

sairedis:
* 326b630 2022-10-21 | [gbsyncd] Add asic db prefix for channel NOTIFICATIONS (#1129) (HEAD -> 202205) [Junhua Zhai]

platform-daemon:
* 6dbda9b 2022-10-25 | [ycabled] fix no port/state returned by grpc server (#308) (HEAD -> 202205) [vdahiya12]
* 3d1228a 2022-10-20 | Fix xcvrd to support 400G ZR optic (#293) [Bohan Yang]

platform-common:
* c04d710 2022-09-29 | Read CMIS data path state duration (#312) (HEAD -> 202205) [Bohan Yang]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants