[build]: put stretch debian packages under target/debs/stretch/ #2519
Conversation
debian packages for stretch are separated from jessie debian packages Signed-off-by: Guohan Lu <gulv@microsoft.com>
Signed-off-by: Guohan Lu <gulv@microsoft.com>
Signed-off-by: Guohan Lu <gulv@microsoft.com>
|
@lguohan: Could you please provide a brief description of the new intended package directory structure and build process so that I can better review the changes? |
|
what about other platforms? despite mlnx and vs? |
Signed-off-by: Guohan Lu <gulv@microsoft.com>
|
@NStetskovych, it looks cavium platform did not put the kernel drivers into stretch directory. I fixed the problem, however, I do not really have a way to validate the image. can you check? |
|
@jleveque , add description of the changes. |
|
I believe this PR introduced a new build failure on top of a (long-existing) build failure in the p4 platform. See https://sonic-jenkins.westus2.cloudapp.azure.com/job/p4/job/buildimage-p4-all/950/. |
| @@ -103,6 +103,7 @@ DOCKER_BUILD = docker build --no-cache \ | |||
|
|
|||
| SONIC_BUILD_INSTRUCTION := make \ | |||
| -f slave.mk \ | |||
| BLDENV=$(BLDENV) \ | |||
There was a problem hiding this comment.
BLDENV [](start = 27, length = 6)
slave.mk could detect the BLDENV from /etc/os-release. We should not treat it as a parameter.
There was a problem hiding this comment.
good suggestion, I'll try later.
| @@ -24,10 +24,18 @@ SRC_PATH = src | |||
| RULES_PATH = rules | |||
| TARGET_PATH = target | |||
| DOCKERS_PATH = dockers | |||
| ifdef BLDENV | |||
There was a problem hiding this comment.
BLDENV [](start = 6, length = 6)
We should assume BLDENV always defined. either STRETCH or JESSIE, and SID in future.
If keep backward compatibility, we could create target/debs as symlink to target/jessie/debs
There was a problem hiding this comment.
Actually backward compatibility should not be an issue. It is easy to fix build script or jenkins script. If this is true, we don't need a symlink.
In reply to: 275602303 [](ancestors = 275602303)
debian packages for stretch are separated from jessie debian packages
Signed-off-by: Guohan Lu gulv@microsoft.com
- What I did
- How I did it
- How to verify it
build the image and test
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)