[ntp]: Build 4.2.6 locally.

[praveen-li]

Need to build NTP 4.2.6 locally due to a Bug in NTP 4.2.6.

Changes:
1.) Remove 'apt-get ntp' step. File: build_debian.sh.
2.) Add NTP package as part of base image. File: slave.mk and in files/build_templates/sonic_debian_extension.j2.
3.) NTP Makefile for Sonic Build System. File: rules/ntp.mk.
4.) NTP Source Makefile. File: src/ntp/Makefile.
5.) Patch to fix the issue. File: src/ntp/patch.

Signed-off-by: Praveen Chaudharypchaudhary@linkedin.com

- What I did

I build NTP 4.2.6 locally by fetching dsc file from debian site. This is done to address a bug in NTP 4.2.6.

Bug Description:
In NTP 1:4.2.6 code. File: ntpd/ntp_io.c. Function: process_routing_msgs().
Asyncio reader is disabled, if any error is returned from read call. Function read() may return ENOBUFS if kernel returns ENOBUFS in netlink due to memory constraints or due to link flap. Due to this ntp stops syncing time even when link comes back. Workaround was to restart NTP process, which is not acceptable. Kindle see below code:

cnt = read(reader->fd, buffer, sizeof(buffer));

if (cnt < 0) { 
      msyslog(LOG_ERR,
        "i/o error on routing socket %m - disabling");<<<<<<<<<<
    remove_asyncio_reader(reader);
    delete_asyncio_reader(reader);
}
    return;
}

To solve this, below fix is applied. Note: Fix exists in NTP 4.2.8, but NTP 4.2.8 is not available for Jessie. Also due to oher dependecies, it was decided to build NTP 4.2.6 with fix, instead of NTP 4.2.8

Code after Fix:

4431 
4432     if (cnt < 0) {
4433        if (errno == ENOBUFS) {
4434         msyslog(LOG_ERR, "routing socket reports: %m");
4435        } else {
4436         msyslog(LOG_ERR,
4437             "i/o error on routing socket %m - disabling");
4438         remove_asyncio_reader(reader);
4439         delete_asyncio_reader(reader);
4440        }
4441         return;
4442     }

-
How I did it

I build NTP package using below changes and applied point fix.

Changes:
1.) Remove 'apt-get ntp' step. File: build_debian.sh.
2.) Add NTP package as part of base image. File: slave.mk and in files/build_templates/sonic_debian_extension.j2.
3.) NTP Makefile for Sonic Build System. File: rules/ntp.mk.
4.) NTP Source Makefile. File: src/ntp/Makefile.
5.) Patch to fix the issue. File: src/ntp/patch.

- How to verify it

Ran Link Flap Operation:

Below Error was seen before fix:
syslog.93.gz:Feb  2 12:16:18.229161 falco-test-dut01 ERR ntpd[1222]: i/o error on routing socket No buffer space available - disabling
syslog.93.gz:Feb  2 12:20:45.429109 falco-test-dut01 ERR ntpd[27281]: i/o error on routing socket No buffer space available - disabling

Also command "ntpq -p" shows:

No association ID's returned

After Fix:
We see new Error MSG:

syslog.9.gz:Feb  5 03:03:47.180823 falco-test-dut01 ERR ntpd[6153]: routing socket reports: No buffer space available
syslog.9.gz:Feb  5 03:03:47.240752 falco-test-dut01 ERR ntpd[6153]: routing socket reports: No buffer space available
syslog.9.gz:Feb  5 03:03:48.805217 falco-test-dut01 ERR ntpd[6153]: routing socket reports: No buffer space available

After fix "ntpq -p" output:

     remote           refid      st t when poll reach   delay   offset  jitter
==============================================================================
 10.0.0.1        .XFAC.          16 u    - 1024    0    0.000    0.000   0.000
 10.0.0.2        .XFAC.          16 u    - 1024    0    0.000    0.000   0.000

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

[lguohan]

please resolve conflict and rebase to latest master.

[lguohan]

since stretch is already using 4.2.8, I am not sure why we are moving back to 4.2.6.

[praveen-li]

since stretch is already using 4.2.8, I am not sure why we are moving back to 4.2.6.

Yup now after stretch changes, we do not need to build ntp 4.2.6 and have the point fix.
NTP 4.2.8 already have the fix for the bug which I was trying to address. We can discard this PR now.

[lguohan]

agree, can you open pr on 201803 branch? Looks like we need it there?

[praveen-li]

Done. Thanks, Regards Praveen From: lguohan <notifications@github.com> Reply-To: Azure/sonic-buildimage <reply@reply.github.com> Date: Tuesday, February 5, 2019 at 1:30 PM To: Azure/sonic-buildimage <sonic-buildimage@noreply.github.com> Cc: Praveen Chaudhary <pchaudhary@linkedin.com>, State change <state_change@noreply.github.com> Subject: Re: [Azure/sonic-buildimage] [ntp]: Build 4.2.6 locally. (#2528) agree, can you open pr on 201803 branch? Looks like we need it there? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fsonic-buildimage%2Fpull%2F2528%23issuecomment-460811437&data=02%7C01%7Cpchaudhary%40linkedin.com%7Cccf427986d6148de30d108d68bb1369a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636849990572187683&sdata=WNYaiIIlE014KcGHFdU%2F%2BbvMKD7C2yar72UIuSeMvg8%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAk-Tva8axTYWSnaTUeOFwtGYLQ3KzkBhks5vKfgMgaJpZM4ajrhN&data=02%7C01%7Cpchaudhary%40linkedin.com%7Cccf427986d6148de30d108d68bb1369a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636849990572187683&sdata=qH7%2BfPBQsni43%2FBnLCuH8Tc7%2FNldedLeSTR8QLw3OJo%3D&reserved=0>.