Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature to run an option platform specific script on the first boot #2531

Closed
wants to merge 2 commits into from
Closed

Feature to run an option platform specific script on the first boot #2531

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25fa459
Added the feature to run an option platform specific script on the fi…
olivier-singla Feb 6, 2019
8142b86
Better use $platform instead of $device_platform
olivier-singla Feb 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions files/image_config/platform/rc.local
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,10 @@ if [ -f $FIRST_BOOT_FILE ]; then
mv /host/grub.cfg /host/grub/grub.cfg
fi

# If there is a platform dependant script, execute it
if [ -x /usr/share/sonic/device/${onie_platform}/platform_setup ]; then
/usr/share/sonic/device/${onie_platform}/platform_setup
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to be $platform, not all platform are onie platform

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

porting guide needs to be updated. https://github.com/Azure/SONiC/wiki/Porting-Guide

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I committed changes to use platform instead of device_platform.
Regarding the proposed changes in the wiki file Porting-Guide.md, how can I submit them?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to open a pull request against the https://github.com/Azure/SONiC repo using the same procedure you used to generate this pull request.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see Porting-Guide.md when I clone git@github.com:Azure/SONiC.git

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes, because it's part of the wiki, and GitHub treats the wiki differently than the repo itself. For now, you can open an issue in that repo and paste your proposed changes for the file in the description.

fi
firsttime_exit
fi

Expand Down