Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[201803] [apt] Instruct apt-get to NOT check the "Valid Until" date in Release files #2611

Closed
wants to merge 2 commits into from
Closed

[201803] [apt] Instruct apt-get to NOT check the "Valid Until" date in Release files #2611

wants to merge 2 commits into from

Conversation

jleveque
Copy link
Contributor

- What I did

SONiC image builds were failing due to expired "Valid Until" date in jessie-backports/InRelease and stretch-backports/InRelease files in Debian repo, causing the SONiC build to fail with a message like the following:

Step 9/27 : RUN apt-get update
 ---> Running in 7e733c41d938
Ign:1 http://debian-archive.trafficmanager.net/debian stretch InRelease
Get:2 http://debian-archive.trafficmanager.net/debian-security stretch/updates InRelease [94.3 kB]
Get:3 http://debian-archive.trafficmanager.net/debian stretch-backports InRelease [91.9 kB]
Get:4 http://debian-archive.trafficmanager.net/debian stretch Release [118 kB]
Get:5 http://debian-archive.trafficmanager.net/debian stretch Release.gpg [2434 B]
Get:6 http://debian-archive.trafficmanager.net/debian-security stretch/updates/contrib Sources [1384 B]
Get:7 http://debian-archive.trafficmanager.net/debian-security stretch/updates/non-free Sources [1216 B]
Get:8 http://debian-archive.trafficmanager.net/debian-security stretch/updates/main Sources [193 kB]
Get:9 http://debian-archive.trafficmanager.net/debian-security stretch/updates/contrib amd64 Packages [1760 B]
Get:10 http://debian-archive.trafficmanager.net/debian-security stretch/updates/non-free amd64 Packages [1600 B]
Get:11 http://debian-archive.trafficmanager.net/debian-security stretch/updates/main amd64 Packages [474 kB]
Get:12 http://debian-archive.trafficmanager.net/debian stretch/non-free Sources [79.4 kB]
Get:13 http://debian-archive.trafficmanager.net/debian stretch/main Sources [6746 kB]
Get:14 http://debian-archive.trafficmanager.net/debian stretch/contrib Sources [44.7 kB]
Get:15 http://debian-archive.trafficmanager.net/debian stretch/contrib amd64 Packages [50.9 kB]
Get:16 http://debian-archive.trafficmanager.net/debian stretch/non-free amd64 Packages [78.3 kB]
Get:17 http://debian-archive.trafficmanager.net/debian stretch/main amd64 Packages [7084 kB]
Reading package lists...
Release file for http://debian-archive.trafficmanager.net/debian/dists/stretch-backports/InRelease is expired (invalid since 7h 33min 52s). Updates for this repository will not be applied.
The command '/bin/sh -c apt-get update' returned a non-zero code: 100
[  FAIL LOG END  ] [ target/docker-base-stretch.gz ]

This change prevents the build from failing under these circumstances.

- How I did it

Instruct apt-get to NOT check the "Valid Until" date in Release files by adding a new file inside base image and Docker images, /etc/apt/apt.conf.d/no-check-valid-until. The change was applied to the base image, docker-base and sonic-slave.

- How to verify it

Ensure build succeeds even if the "Valid Until" date in some Debian Release/InRelease files is expired.

@jleveque jleveque self-assigned this Feb 27, 2019
@jleveque
Copy link
Contributor Author

Closing because the "Valid Until" date has since been updated and the change has now propagated to the Azure Debian mirror. Will revisit in the future if this becomes an issue again.

@jleveque jleveque closed this Feb 27, 2019
@jleveque jleveque deleted the apt_no_check_valid_until_201803 branch February 27, 2019 18:58
@qiluo-msft
Copy link
Collaborator

We could still PR some refactor work you did here.

@jleveque
Copy link
Contributor Author

@qiluo-msft: True. Which changes are you referring to? In this branch the only thing I can think of is the change to simplify build_debian.sh by copying all files. Anything else?

@qiluo-msft
Copy link
Collaborator

anything not related to the title 'Valid Until'

@Junchao-Mellanox Junchao-Mellanox mentioned this pull request Jan 30, 2023
Closed
dprital added a commit to dprital/sonic-buildimage that referenced this pull request Jan 30, 2023
@dprital
[submodule] Advance sonic-swss pointer
78f8d99 
Update sonic-swss submodule pointer to include the following:
* a2a483d [acl] Add new ACL key BTH_OPCODE and AETH_SYNDROME  ([sonic-net#2617](sonic-net/sonic-swss#2617))
* 9d1f66b [bfdorch] add local discriminator to state DB ([sonic-net#2629](sonic-net/sonic-swss#2629))
* c54b3d1 Vxlan tunnel endpoint custom monitoring APPL DB table. ([sonic-net#2589](sonic-net/sonic-swss#2589))
* 7f03db2 Fix potential risks ([sonic-net#2516](sonic-net/sonic-swss#2516))
* 383ee68 [refactor]Refactoring sai handle status ([sonic-net#2621](sonic-net/sonic-swss#2621))
* cd95972 Fix issue 13341 ARP entry can be out of sync between kernel and APPL_DB if multiple updates are received from RTNL ([sonic-net#2619](sonic-net/sonic-swss#2619))
* a01470f Remove TODO comments that are no longer relevant ([sonic-net#2622](sonic-net/sonic-swss#2622))
* d058390 Changed the BFD default detect multiplier to 10x ([sonic-net#2614](sonic-net/sonic-swss#2614))
* d78b528 [MuxOrch] Enabling neighbor when adding in active state ([sonic-net#2601](sonic-net/sonic-swss#2601))
* 4ebdad1 [routesync] Fix for stale dynamic neighbor ([sonic-net#2553](sonic-net/sonic-swss#2553))
* 8857f92 Added new attributes for Vnet and Vxlan ecmp configurations. ([sonic-net#2584](sonic-net/sonic-swss#2584))
* b6bbc3e Revert [voq][chassis]Add show fabric counters port/queue commands (2522) ([sonic-net#2611](sonic-net/sonic-swss#2611))
* 52406e2 Add missing parameter to on_switch_shutdown_request method. ([sonic-net#2567](sonic-net/sonic-swss#2567))
* 4ac9ad9 Increase diff coverage to 80% ([sonic-net#2599](sonic-net/sonic-swss#2599))
* 8a0bb36 Handle Mac address 'none' ([sonic-net#2593](sonic-net/sonic-swss#2593))
* f496ab3 [vstest] Only collect stdout of orchagent_restart_check in vstest ([sonic-net#2597](sonic-net/sonic-swss#2597))
* 1dab495 Avoid aborting orchagent when setting TUNNEL attributes ([sonic-net#2591](sonic-net/sonic-swss#2591))
* 4395cea Fix neighbor doesn't update all attribute ([sonic-net#2577](sonic-net/sonic-swss#2577))

Signed-off-by: dprital <drorp@nvidia.com>
liat-grozovik pushed a commit that referenced this pull request Feb 1, 2023
@dprital
[submodule] Advance sonic-swss pointer (#13551)
4c3aafc 
Update sonic-swss submodule pointer to include the following:
* a2a483d [acl] Add new ACL key BTH_OPCODE and AETH_SYNDROME  ([#2617](sonic-net/sonic-swss#2617))
* 9d1f66b [bfdorch] add local discriminator to state DB ([#2629](sonic-net/sonic-swss#2629))
* c54b3d1 Vxlan tunnel endpoint custom monitoring APPL DB table. ([#2589](sonic-net/sonic-swss#2589))
* 7f03db2 Fix potential risks ([#2516](sonic-net/sonic-swss#2516))
* 383ee68 [refactor]Refactoring sai handle status ([#2621](sonic-net/sonic-swss#2621))
* cd95972 Fix issue 13341 ARP entry can be out of sync between kernel and APPL_DB if multiple updates are received from RTNL ([#2619](sonic-net/sonic-swss#2619))
* a01470f Remove TODO comments that are no longer relevant ([#2622](sonic-net/sonic-swss#2622))
* d058390 Changed the BFD default detect multiplier to 10x ([#2614](sonic-net/sonic-swss#2614))
* d78b528 [MuxOrch] Enabling neighbor when adding in active state ([#2601](sonic-net/sonic-swss#2601))
* 4ebdad1 [routesync] Fix for stale dynamic neighbor ([#2553](sonic-net/sonic-swss#2553))
* 8857f92 Added new attributes for Vnet and Vxlan ecmp configurations. ([#2584](sonic-net/sonic-swss#2584))
* b6bbc3e Revert [voq][chassis]Add show fabric counters port/queue commands (2522) ([#2611](sonic-net/sonic-swss#2611))
* 52406e2 Add missing parameter to on_switch_shutdown_request method. ([#2567](sonic-net/sonic-swss#2567))
* 4ac9ad9 Increase diff coverage to 80% ([#2599](sonic-net/sonic-swss#2599))
* 8a0bb36 Handle Mac address 'none' ([#2593](sonic-net/sonic-swss#2593))
* f496ab3 [vstest] Only collect stdout of orchagent_restart_check in vstest ([#2597](sonic-net/sonic-swss#2597))
* 1dab495 Avoid aborting orchagent when setting TUNNEL attributes ([#2591](sonic-net/sonic-swss#2591))
* 4395cea Fix neighbor doesn't update all attribute ([#2577](sonic-net/sonic-swss#2577))

Signed-off-by: dprital <drorp@nvidia.com>
mihirpat1 pushed a commit to mihirpat1/sonic-buildimage that referenced this pull request Jun 14, 2023
@arlakshm
Revert "[voq][chassis]Add show fabric counters port/queue commands (s…
b6bbc3e 
…onic-net#2522)" (sonic-net#2611)

This reverts commit beaac71.
Reverts sonic-net/sonic-swss#2522

Fixes sonic-net#13324
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan Awaiting requested review from lguohan

@qiluo-msft qiluo-msft Awaiting requested review from qiluo-msft

@yxieca yxieca Awaiting requested review from yxieca

Assignees

@jleveque jleveque

Labels
Critical ❗ Enhancement ➕
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jleveque @qiluo-msft