Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[swss/syncd] cold start syncd service by swss in attach method #2639

Merged
merged 1 commit into from
Mar 5, 2019

Conversation

yxieca
Copy link
Contributor

@yxieca yxieca commented Mar 4, 2019

- What I did

start() is called by service startPre method, which is blocking. Starting syncd service here is causing deadlock.

attach() is called by service start method, which is non-blocking. Starting syncd service here is fine.

Signed-off-by: Ying Xie ying.xie@microsoft.com

- How to verify it
Tested following scenarios:

  • cold reboot
  • cold restart swss (including config load_minigraph)
  • warm restart swss
  • warm restart syncd
  • warm reboot
    (Note that we don't support cold restart syncd).

start() is called by service startPre method, which is blocking. Starting
syncd service here is causing deadlock.

attach() is called by service start method, which is non-blocking.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@yxieca yxieca requested a review from jleveque March 4, 2019 19:34
@yxieca yxieca changed the title [swss/syncd] cold start syncd service in swss in attach method [swss/syncd] cold start syncd service by swss in attach method Mar 4, 2019
@yxieca yxieca merged commit 66f5202 into sonic-net:master Mar 5, 2019
@yxieca yxieca deleted the swss branch March 5, 2019 00:46
@jipanyang
Copy link
Collaborator

When was this introduced? with #2634 ?

@jleveque
Copy link
Contributor

jleveque commented Mar 6, 2019

@jipanyang: Yes.

@yxieca
Copy link
Contributor Author

yxieca commented Mar 7, 2019

Made to 201811 branch on 3/6/2019

yxieca added a commit that referenced this pull request Mar 7, 2019
start() is called by service startPre method, which is blocking. Starting
syncd service here is causing deadlock.

attach() is called by service start method, which is non-blocking.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 10, 2019
…-net#2639)

start() is called by service startPre method, which is blocking. Starting
syncd service here is causing deadlock.

attach() is called by service start method, which is non-blocking.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 10, 2019
…-net#2639)

start() is called by service startPre method, which is blocking. Starting
syncd service here is causing deadlock.

attach() is called by service start method, which is non-blocking.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 10, 2019
…-net#2639)

start() is called by service startPre method, which is blocking. Starting
syncd service here is causing deadlock.

attach() is called by service start method, which is non-blocking.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Jan 25, 2023
swss:
* f28d6622 2023-01-25 | [portinit] Do not call GET on SAI_PORT_ATTR_SPEED when AUTONEG is enabled (sonic-net#2484) (sonic-net#2639) (github/202012, 202012) [Ying Xie]
* 217f7f00 2023-01-21 | Cherry pick of sonic-net/sonic-swss#2589 (sonic-net#2627) [siqbal1986]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca added a commit that referenced this pull request Jan 26, 2023
swss:
* f28d6622 2023-01-25 | [portinit] Do not call GET on SAI_PORT_ATTR_SPEED when AUTONEG is enabled (#2484) (#2639) (github/202012, 202012) [Ying Xie]
* 217f7f00 2023-01-21 | Cherry pick of sonic-net/sonic-swss#2589 (#2627) [siqbal1986]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
qiluo-msft pushed a commit that referenced this pull request Feb 9, 2023
```
39cdb49c7 [202012][show] Add bgpraw to show run all (#2639)
b3ebba2ca [202012][show] add new CLI to show tunnel route objects #2255 (#2659)
d08f59b9f Fixed a bug in "show vnet routes all" causing screen overrun. (#2644) (#2654)
a996abdb5 [202012][show] show logging CLI support for logs stored in tmpfs (#2652)
c60f771c0 [202012][show_bfd] add local discriminator in show bfd command (#2616)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants