Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of HwSKU Mellanox-SN2700-C28D8 #2690

Merged
merged 2 commits into from
Mar 28, 2019

Conversation

andriymoroz-mlnx
Copy link
Collaborator

@andriymoroz-mlnx andriymoroz-mlnx commented Mar 21, 2019

Signed-off-by: Andriy Moroz c_andriym@mellanox.com

- What I did

- How I did it

- How to verify it

  1. Installed some latest 201803 image we had
  2. Built and installed on switch sonic-device-data_1.0-1_all.deb with the new HwSKU configs on running switch (dpkg -i …)
  3. Updated minigraph to match port_config.ini
  4. Stopped services and removed syncd container
    (not sure this is really needed, just to make sure it will pick up a new sai prorile)
  5. Loaded updated minigraph
  6. Test command line sudo sfputil show presence and there is no exception.

Ports were created as expected with the speed according to the schema provided by Qi.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
Copy link
Collaborator

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also cherry-pick to master and all release branch after 201803

@lguohan
Copy link
Collaborator

lguohan commented Mar 22, 2019

it should be other way around. the PR should be generated against master, then cherry-pick into a release branch.

Copy link
Collaborator

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please submit pr into master branch.

@andriymoroz-mlnx
Copy link
Collaborator Author

cannot be directly merged from master because in master qos config is a template while in 201803 it is a json
To unify need to merge #2023 to 201803 or I can create a separate PR for master

Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
@lguohan
Copy link
Collaborator

lguohan commented Mar 25, 2019

@andriymoroz-mlnx , can you mark this as ready for review?

@andriymoroz-mlnx andriymoroz-mlnx marked this pull request as ready for review March 26, 2019 08:02
@lguohan lguohan merged commit cbca684 into sonic-net:201803 Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants