[jessie based docker] remove dependency on some retired jessie repos #2707

yxieca · 2019-03-26T18:03:14Z

- What I did
Some Jessie repo were retired recently. This PR addresses following 2 issues:

Jessie-backports has been retired. we need to use the rsyslog comes with Jessie.
The SONiC base image is running stretch already. We believe running older version of rsyslog in dockers is safe.
Jessie base container downloaded from docker repo still references jessie-updates under main repo. We need to remove it from sources.list.

- How to verify it
build a sonic image.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

jleveque · 2019-03-26T18:11:32Z

Suggest changing PR title to [docker-base] Remove dependency on retired jessie-backports repo

jleveque

Suggest to also remove the line echo "deb http://debian-archive.trafficmanager.net/debian/ jessie-backports main contrib non-free" >> /etc/apt/sources.list from sonic-slave/Dockerfile and update title to [docker-base][sonic-slave] Remove dependency on retired jessie-backports repo

The downloaded Jessie docker image still reference jessie-updates. Removing it from the list. Signed-off-by: Ying Xie <ying.xie@microsoft.com>

yxieca · 2019-03-26T20:36:07Z

Adding more changes. This might fix all issues? fingers crossed now.

sonic-slave/Dockerfile

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

jipanyang · 2019-03-27T01:31:05Z

Any one also seeing this error even after the change:

Removing intermediate container 091b0d74ba27
 ---> 105eac3dcad4
Step 10/36 : RUN apt-get -y install ca-certificates-java=20161107~bpo8+1 openjdk-8-jdk
 ---> Running in 28e4fed66c1d
Reading package lists...
Building dependency tree...
Reading state information...
Package openjdk-8-jdk is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

E: Version '20161107~bpo8+1' for 'ca-certificates-java' was not found
E: Package 'openjdk-8-jdk' has no installation candidate
The command '/bin/sh -c apt-get -y install ca-certificates-java=20161107~bpo8+1 openjdk-8-jdk' returned a non-zero code: 100
Makefile.work:137: recipe for target 'list' failed
make[1]: *** [list] Error 100

yxieca · 2019-03-27T01:35:13Z

Jipan,

Not yet. I think I can build sonic-slave no problem with changes in this PR.

Regards,
Ying

yxieca · 2019-03-27T01:37:14Z

It is commented out:

sonic-slave/Dockerfile:# RUN apt-get -y install ca-certificates-java=20161107~bpo8+1 openjdk-8-jdk

Why are you hitting the issue?

jleveque · 2019-03-27T01:37:27Z

@jipanyang: the line RUN apt-get -y install ca-certificates-java=20161107~bpo8+1 openjdk-8-jdk has been commented out in the master branch.

jipanyang · 2019-03-27T03:40:27Z

@jipanyang: the line RUN apt-get -y install ca-certificates-java=20161107~bpo8+1 openjdk-8-jdk has been commented out in the master branch.

Thanks, my local code needs update. Please ignore the issue.

…2707) * [jessie repo] remove one dependency on jessie-backport repo Signed-off-by: Ying Xie <ying.xie@microsoft.com> * [build] remove dependency on retried jessie-backports repo The downloaded Jessie docker image still reference jessie-updates. Removing it from the list. Signed-off-by: Ying Xie <ying.xie@microsoft.com> * fix typo * move chunk * [docker-ptf] avoid using retired Jessie repos Signed-off-by: Ying Xie <ying.xie@microsoft.com>

TencentSwitchGroup · 2019-03-28T00:48:51Z

dockers/docker-base/Dockerfile.j2

    less

-# Install a newer version of rsyslog from jessie-backports in hopes of
-# eliminating memory leaks


Do we need to update rsyslog version?

We may want to consider it for the 201811 branch, because the Docker images are still based on Jessie (I just did this for the 201803 branch).

For the master branch, we are upgrading all images to Stretch, which has the newer version of rsyslog.

"I just did this for the 201803 branch"
How can I upgrade syslog now for the 201811 branch

@yinshuangshuang: Thank you for the suggestion! I have created a PR to upgrade the version of rsyslog installed in the Docker containers in the 2018011 branch here: #3127.

cony7642 · 2019-04-09T01:21:02Z

Could I merge the changed files into 201811 branch?

jleveque · 2019-04-09T01:23:41Z

@cony7642: This commit was already cherry-picked into the 201811 branch: 5043e22

cony7642 · 2019-04-09T01:55:05Z

@jleveque
I merge the 5043e22 to my local 201811 branch but make sonic-broadcom.bin will error as below

++ echo 201811.0-dirty-20190408.173736
+ sudo LANG=C chroot ./fsroot docker tag docker-snmp-sv2:latest docker-snmp-sv2:201811.0-dirty-20190408.173736
+ sudo LANG=C chroot ./fsroot docker load
open /var/lib/docker/tmp/docker-import-810914033/repositories: no such file or directory

Whether I need to do some action such as clean something before making sonic-broadcom.bin?

jleveque · 2019-04-09T02:15:40Z

@cony7642: You can try make clean, but it seems there are issues with your Docker environment.

It's probably best to pull down the head of the 201811 branch, since the commit is now in that branch.

…onic-net#2707) * [jessie repo] remove one dependency on jessie-backport repo Signed-off-by: Ying Xie <ying.xie@microsoft.com> * [build] remove dependency on retried jessie-backports repo The downloaded Jessie docker image still reference jessie-updates. Removing it from the list. Signed-off-by: Ying Xie <ying.xie@microsoft.com> * fix typo * move chunk * [docker-ptf] avoid using retired Jessie repos Signed-off-by: Ying Xie <ying.xie@microsoft.com>

qiluo-msft · 2019-05-17T21:01:24Z

dockers/docker-base/Dockerfile.j2

@@ -1,5 +1,8 @@
 FROM debian:jessie

+## Remove retired jessie-updates repo
+RUN sed -i '/deb http:\/\/deb.debian.org\/debian jessie-updates main/d' /etc/apt/sources.list


This is not needed. Later

COPY ["sources.list", "/etc/apt/sources.list"]

…onic-net#2707) * [jessie repo] remove one dependency on jessie-backport repo Signed-off-by: Ying Xie <ying.xie@microsoft.com> * [build] remove dependency on retried jessie-backports repo The downloaded Jessie docker image still reference jessie-updates. Removing it from the list. Signed-off-by: Ying Xie <ying.xie@microsoft.com> * fix typo * move chunk * [docker-ptf] avoid using retired Jessie repos Signed-off-by: Ying Xie <ying.xie@microsoft.com> github PR Link: https://github.com/Azure/sonic-buildimage/pull/2707/files RB=1622918 G=lnos-reviewers R=pchaudhary,pmao,rmolina,samaity,sfardeen,zxu A=zxu

[jessie repo] remove one dependency on jessie-backport repo

3a2ff72

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

yxieca requested review from jleveque and pavel-shirshov March 26, 2019 18:03

yxieca changed the title ~~[jessie repo] remove one dependency on jessie-backports repo~~ [docker-base] remove dependency on retired jessie-backports repo Mar 26, 2019

jleveque approved these changes Mar 26, 2019 •

edited

Loading

View reviewed changes

yxieca added the Request for 201811 Branch label Mar 26, 2019

jleveque suggested changes Mar 26, 2019

View reviewed changes

[build] remove dependency on retried jessie-backports repo

6320eb3

The downloaded Jessie docker image still reference jessie-updates. Removing it from the list. Signed-off-by: Ying Xie <ying.xie@microsoft.com>

fix typo

215fe61

yxieca changed the title ~~[docker-base] remove dependency on retired jessie-backports repo~~ [docker-base][sonic-slave] remove dependency on some retired jessie repos Mar 26, 2019

jleveque reviewed Mar 26, 2019

View reviewed changes

sonic-slave/Dockerfile Outdated Show resolved Hide resolved

move chunk

b84b670

jleveque approved these changes Mar 26, 2019

View reviewed changes

yxieca added Bug 🐛 Critical ❗ and removed Bug 🐛 labels Mar 27, 2019

[docker-ptf] avoid using retired Jessie repos

c27d4fa

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

yxieca changed the title ~~[docker-base][sonic-slave] remove dependency on some retired jessie repos~~ [jessie based docker] remove dependency on some retired jessie repos Mar 27, 2019

jleveque self-requested a review March 27, 2019 01:07

jleveque approved these changes Mar 27, 2019

View reviewed changes

yxieca merged commit 9af7d21 into sonic-net:master Mar 27, 2019

yxieca deleted the build branch March 27, 2019 06:46

yxieca added the Included in 201811 Branch label Mar 27, 2019

TencentSwitchGroup reviewed Mar 28, 2019

View reviewed changes

qiluo-msft reviewed May 17, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[jessie based docker] remove dependency on some retired jessie repos #2707

[jessie based docker] remove dependency on some retired jessie repos #2707

yxieca commented Mar 26, 2019 •

edited

Loading

jleveque commented Mar 26, 2019

jleveque left a comment

yxieca commented Mar 26, 2019

jipanyang commented Mar 27, 2019

yxieca commented Mar 27, 2019

yxieca commented Mar 27, 2019

jleveque commented Mar 27, 2019

jipanyang commented Mar 27, 2019

TencentSwitchGroup Mar 28, 2019

jleveque Mar 28, 2019

yinshuangshuang Jul 4, 2019

jleveque Jul 5, 2019

cony7642 commented Apr 9, 2019

jleveque commented Apr 9, 2019

cony7642 commented Apr 9, 2019

jleveque commented Apr 9, 2019 •

edited

Loading

qiluo-msft May 17, 2019

[jessie based docker] remove dependency on some retired jessie repos #2707

[jessie based docker] remove dependency on some retired jessie repos #2707

Conversation

yxieca commented Mar 26, 2019 • edited Loading

jleveque commented Mar 26, 2019

jleveque left a comment

Choose a reason for hiding this comment

yxieca commented Mar 26, 2019

jipanyang commented Mar 27, 2019

yxieca commented Mar 27, 2019

yxieca commented Mar 27, 2019

jleveque commented Mar 27, 2019

jipanyang commented Mar 27, 2019

TencentSwitchGroup Mar 28, 2019

Choose a reason for hiding this comment

jleveque Mar 28, 2019

Choose a reason for hiding this comment

yinshuangshuang Jul 4, 2019

Choose a reason for hiding this comment

jleveque Jul 5, 2019

Choose a reason for hiding this comment

cony7642 commented Apr 9, 2019

jleveque commented Apr 9, 2019

cony7642 commented Apr 9, 2019

jleveque commented Apr 9, 2019 • edited Loading

qiluo-msft May 17, 2019

Choose a reason for hiding this comment

yxieca commented Mar 26, 2019 •

edited

Loading

jleveque commented Apr 9, 2019 •

edited

Loading