Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to debian python-scapy (2.4.0-2) to fix scapy crash seen with 2.3.3-1 #2745

Merged
merged 2 commits into from
Apr 5, 2019
Merged

Update to debian python-scapy (2.4.0-2) to fix scapy crash seen with 2.3.3-1 #2745

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d93b3aa
Fix scapy crash problem with debian python-scapy (2.4.0-2)
jipanyang Apr 3, 2019
d54abd7
Switch to pip for scap 2.4.2 install
jipanyang Apr 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dockers/docker-base-stretch/sources.list
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@ deb-src http://debian-archive.trafficmanager.net/debian/ stretch main contrib no
deb http://debian-archive.trafficmanager.net/debian-security/ stretch/updates main contrib non-free
deb-src http://debian-archive.trafficmanager.net/debian-security/ stretch/updates main contrib non-free
deb http://debian-archive.trafficmanager.net/debian/ stretch-backports main contrib non-free
deb http://debian-archive.trafficmanager.net/debian/ unstable main contrib non-free
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buster has the same package, let's use buster.

https://packages.debian.org/search?suite=buster&keywords=python-scapy

2 changes: 1 addition & 1 deletion dockers/docker-orchagent/Dockerfile.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ RUN apt-get update

RUN apt-get install -f -y ifupdown arping libdbus-1-3 libdaemon0 libjansson4 libpython2.7 iproute2

RUN apt-get install -f -y ndisc6 tcpdump python-scapy
RUN apt-get install -f -y ndisc6 tcpdump python-scapy=2.4.0-2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we install scapy through pip instead so we don't need include debian unstable repo?
for example use 2.4.2 version:
RUN pip install scapy==2.4.2

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea.

## Install redis-tools dependencies
## TODO: implicitly install dependencies
RUN apt-get -y install libjemalloc1
Expand Down