[docker/snmp] Allow snmp container to use python smbus #2772
Conversation
build_debian.sh
Outdated
| @@ -249,6 +249,10 @@ sudo LANG=C DEBIAN_FRONTEND=noninteractive chroot $FILESYSTEM_ROOT apt-get -y in | |||
| locales \ | |||
| cgroup-tools | |||
|
|
|||
| ## Note: temporary workaround to allow snmp container to import smbus for arista | |||
| sudo LANG=C DEBIAN_FRONTEND=noninteractive chroot $FILESYSTEM_ROOT apt-get -y install \ | |||
There was a problem hiding this comment.
Should we install python3-smbus to the snmp docker itself?
e,g, change this file:
https://github.com/Azure/sonic-buildimage/blob/master/dockers/docker-snmp-sv2/Dockerfile.j2
There was a problem hiding this comment.
As you can see this Dockerfile extends docker-config-engine which extends docker-base which is jessie based. In jessie there is no such thing as python3-smbus. Stretch will have it once all the docker images will be upgraded to this version.
Also there will be another blocker since we build our own version of python3.6 for snmp. Stretch currently uses python3.5. It likely means that installing python3-smbus will only make it available for python3.5 and not python3.6.
I tried to confine the hack to the snmp container by manually installing the stretch python3-smbus in jessie but that generated a lot of errors so I abandoned this idea. We will be tracking the evolution of all these component and remove these mitigations once we can find a sound solution.
There was a problem hiding this comment.
Could you please use 'pip3.6 install' it from pypi? Then you don't worry about python3.5/3.6, nor about jessie/stretch.
In reply to: 274686749 [](ancestors = 274686749)
There was a problem hiding this comment.
I should have left a bigger comment for this change.
The smbus module is a cpython module and therefore require at least build-essentials and python-dev to compile as part of pip3.6 install.
I felt it was overkill to install the build toolchain install the module and remove the toolchain in the Dockerfile.
There was a problem hiding this comment.
Actually we have similar logic in dockers/docker-snmp-sv2/Dockerfile.j2 already:
- install gcc
- pip install hiredis/pyyaml
- remove gcc
Could you please try this `overkill' method? I prefer it because of binary compatibility issue between Jessie container and Stretch host.
In reply to: 274727333 [](ancestors = 274727333)
rules/docker-snmp-sv2.mk
Outdated
| @@ -14,3 +14,4 @@ $(DOCKER_SNMP_SV2)_RUN_OPT += --net=host --privileged -t | |||
| $(DOCKER_SNMP_SV2)_RUN_OPT += -v /etc/sonic:/etc/sonic:ro | |||
| # mount Arista platform python libraries to support corresponding platforms SNMP power status query | |||
| $(DOCKER_SNMP_SV2)_RUN_OPT += -v /usr/lib/python3/dist-packages/arista:/usr/lib/python3/dist-packages/arista:ro | |||
| $(DOCKER_SNMP_SV2)_RUN_OPT += -v /usr/lib/python3/dist-packages/smbus.cpython-35m-x86_64-linux-gnu.so:/usr/lib/python3/dist-packages/smbus.cpython-36m-x86_64-linux-gnu.so | |||
There was a problem hiding this comment.
DOCKER_SNMP_SV2 [](start = 2, length = 15)
Sorry for missing the context.
Why snmp docker needs smbus? which component needs? for what purpose? #Closed
There was a problem hiding this comment.
On the 7060CX-32S we have to query the power supply status from an smbus device.
We therefore have to use the smbus module to do such query.
Snmp currently loads the platform plugins to provide power supply information, without this fix snmp-agent will throw a backtrace due to the missing module.
Hopefully this is just a temporary fix until STATE_DB contains the power supply information and snmp makes use of it rather than calling into a platform specific script.
There was a problem hiding this comment.
Could you add comment like:
Only for Arista 7060CX-32
temporary workaround to allow snmp container to import smbus for arista
In reply to: 274726238 [](ancestors = 274726238)
Staphylo
force-pushed
the
snmp-psu-smbus
branch
from
19d96a6
to
53b83d1
Compare
Update sonic-utilities submodule pointer to include the following: * 5c9b2177 Fix issue: out of range sflow polling interval is accepted and stored in config_db ([sonic-net#2847](sonic-net/sonic-utilities#2847)) * 72ca4848 Add CLI configuration options for teamd retry count feature ([sonic-net#2642](sonic-net/sonic-utilities#2642)) * 359dfc0c [Clock] Implement clock CLI ([sonic-net#2793](sonic-net/sonic-utilities#2793)) * b316fc27 Add transceiver status CLI to show output from TRANSCEIVER_STATUS table ([sonic-net#2772](sonic-net/sonic-utilities#2772)) * dc59dbd2 Replace pickle by json ([sonic-net#2849](sonic-net/sonic-utilities#2849)) * a66f41c4 [show] replace shell=True, replace xml by lxml, replace exit by sys.exit ([sonic-net#2666](sonic-net/sonic-utilities#2666)) * 57500572 [utilities_common] replace shell=True ([sonic-net#2718](sonic-net/sonic-utilities#2718)) * 6e0ee3e7 [CRM][DASH] Extend CRM utility to support DASH resources. ([sonic-net#2800](sonic-net/sonic-utilities#2800)) * b2c29b0b [config] Generate sysinfo in single asic ([sonic-net#2856](sonic-net/sonic-utilities#2856)) Signed-off-by: dprital <drorp@nvidia.com>
- What I did
The python3-smbus module is installed on the host and shared to the snmp
container via a docker mount.
This is a hack to prevent snmp from installing build-essential to build
a single cpython module.
Once the snmp docker image uses stretch, the python3-smbus should be available there directly.
- How I did it
Installed python3-smbus in the host.
Added a mountpoint for the cpython lib in snmp.