Configure dhcp_relay container hostname from config DB #2820
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Implemented as a result of discussion in #2806.
sed
introduced in #2773 as inline operation can't be applied to/etc/hosts
inside docker container- How I did it
Configure
dhcp_relay
docker hostname in the same way as this is done inhostname-config.sh
- How to verify it
1) Run
dhcp_relay
CT and verify it will pass2)
2.1) manually change 'hostname' in
config_db.json
2.2) run
sudo config reload -y
2.3) check hostname inside
dhcp_relay
container- Description for the changelog
Set proper hostname for dhcp_relay container on startup
@qiluo-msft please review and merge this.