[Sonic-config-engine]: View acls and ports or specifc port configs on sonic switch (Json)

[prprakas]

Following features are added as the part of this PR, this only involves changes done to sonic-config-engine, I will submit a PR for changes done on sonic-utilities.

1. View acl configs
2. View port configs (like speed , lanes index etc)
3. View specific port configs

Signed-off-by: Prem Prakash prprakash@linkedin.com

- What I did
To view port configs and acl configs, added the support to sonic-config-engine and implemented the show commands for it
- How I did it
Modified sonic-cfggen file to add the support for acl and port running config. Even main.py file is modified under sonic-utilities/show folder.
- How to verify it
built sonic-utilities deb package and installed it and also changed the sonic-cfggen file in the switch under /usr/local/bin/sonic-cfggen

Added options interface and accesslist to the runningconfiguration option

admin@lnos-x1-a-csw02:~$ show runningconfiguration ?
Usage: show runningconfiguration [OPTIONS] COMMAND [ARGS]...

Show current running configuration information

Options:
-?, -h, --help Show this message and exit.

Commands:
accesslist Show acl running configuration
all Show full running configuration
bgp Show BGP running configuration
interface Show port running configuration
interfaces Show interfaces running configuration
ntp Show NTP running configuration
snmp Show SNMP information
admin@lnos-x1-a-csw02:~$

ACL config-

admin@lnos-x1-a-csw02:$ show runningconfiguration accesslist
{
"ACL_RULE": {
"NO-NSW-PACL-V4|DEFAULT_DENY": {
"PACKET_ACTION": "DROP",
"IP_TYPE": "IPv4ANY",
"PRIORITY": "0"
},
"NO-NSW-PACL-V4|Rule_20": {
"PACKET_ACTION": "FORWARD",
"DST_IP": "X.X.X.X/24",
"SRC_IP": "X.X.0.0/16",
"IP_TYPE": "IPv4ANY",
"PRIORITY": "999980"
}
}
}
admin@lnos-x1-a-csw02:$

Port configs-

admin@lnos-x1-a-csw02:~$ show runningconfiguration interface
{
"PORT": {
"Ethernet0": {
"index": "1",
"lanes": "65,66,67,68",
"mtu": "9100",
"alias": "Eth1",
"admin_status": "up",
"speed": "100000"
},
"Ethernet4": {
"index": "2",
"lanes": "69,70,71,72",
"mtu": "9100",
"alias": "Eth2",
"admin_status": "up",
"speed": "100000"
},
"Ethernet8": {
"index": "3",
"lanes": "73,74,75,76",
"mtu": "9100",
"alias": "Eth3",
"admin_status": "up",
"speed": "100000"
},
"Ethernet12": {
"index": "4",
"lanes": "77,78,79,80",
"mtu": "9100",
"alias": "Eth4",
"admin_status": "up",
"speed": "100000"
}
}

Port config for a specific port-

admin@lnos-x1-a-csw02:$ show runningconfiguration interface Ethernet0
{
"Ethernet0": {
"admin_status": "up",
"alias": "Eth1",
"index": "1",
"lanes": "65,66,67,68",
"mtu": "9100",
"speed": "100000"
}
}
admin@lnos-x1-a-csw02:$

[prprakas]

retest this please

[prprakas]

retest this please

[prprakas]

retest vs please

[prprakas]

retest this please

[prprakas]

retest vs please

[prprakas]

@lguohan addressed your comments. Please have a look.

[lguohan]

@prprakas , I am not sure I understand your point, the show interface neighbor expected is broken due to this PR, i think.

[lguohan]

please fix show interface neighbor expected

[prprakas]

@lguohan Understood, fixed it under sonic-net/sonic-utilities#584. It seems to be good now, please have a look.

[lguohan]

@prprakas, thanks for the PR. can you update the sonic-utilities submodule in the PR?

[prprakas]

@prprakas, thanks for the PR. can you update the sonic-utilities submodule in the PR?

@lguohan If I understand correctly, I think you are asking for the changes in sonic-utilities for the corresponding show commands. That change was already submitted under sonic-net/sonic-utilities#557 along with this PR and has already been approved.

[lguohan]

for this PR, you should include submodule update for that repo.

[lguohan]

can you resolve the conflict?

[lguohan]

there are still conflict.

[prprakas]

@lguohan I think there have been multiple other commits on src/sonic-utilities which are already included in sonic-buildimage https://github.com/Azure/sonic-buildimage/tree/master/src. I think updating src/sonic-utilities is not needed now.

[prprakas]

@lguohan any thing has changed I see the older tests are failing ? https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/buildimage-vs-image-pr/601/console.

[lguohan]

i think it is the unit test issue, the nightly build succeeded.

[prprakas]

retest this please

[prprakas]

@lguohan looks like similar change has been added under #3248 and it is approved, I think that is the reason these tests are failing for me ?

[prprakas]

@lguohan do you think this PR is needed now, to me it seems like this is already covered in #3248 , let me know what do you think ?

[lguohan]

yes, i think we can drop this pr, but can you fix sonic-utilities?