Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix fast reboot compatibility #3083

Merged
merged 3 commits into from
Jun 26, 2019
Merged

fix fast reboot compatibility #3083

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e5ba644
fix fast reboot compatibility
Jun 25, 2019
66616de
handle review comments
Jun 26, 2019
2722849
add a comment that getBootType code snippet is shared between
Jun 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions files/build_templates/docker_image_ctl.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,14 @@ function updateHostName()
function getBootType()
{
local BOOT_TYPE
Copy link
Collaborator

@qiluo-msft qiluo-msft Jun 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local BOOT_TYPE [](start = 4, length = 15)

This line can be removed. #Closed

case "$(cat /proc/cmdline | grep -o 'SONIC_BOOT_TYPE=\S*' | cut -d'=' -f2)" in
warm*)
case "$(cat /proc/cmdline)" in
*warm*)
Copy link
Collaborator

@qiluo-msft qiluo-msft Jun 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warm [](start = 5, length = 4)

Be more specific SONIC_BOOT_TYPE=warm #Closed

TYPE='warm'
;;
fastfast)
*fastfast*)
Copy link
Collaborator

@qiluo-msft qiluo-msft Jun 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fastfast [](start = 5, length = 8)

Be more specific SONIC_BOOT_TYPE=fastfast #Closed

TYPE='fastfast'
;;
fast*)
*fast*)
Copy link
Collaborator

@qiluo-msft qiluo-msft Jun 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast [](start = 4, length = 6)

This one is also too general. We can match for 2 patterns:

  1. *SONIC_BOOT_TYPE=fast*
  2. *fast-reboot* #Closed

TYPE='fast'
;;
*)
Expand Down Expand Up @@ -167,7 +167,7 @@ start() {
echo "Creating new {{docker_container_name}} container with HWSKU $HWSKU"
{%- endif %}
{%- if sonic_asic_platform == "mellanox" %}
# TODO: Mellanox will remove the --tmpfs exception after SDK socket path changed in new SDK version
# TODO: Mellanox will remove the --tmpfs exception after SDK socket path changed in new SDK version
{%- endif %}
docker create {{docker_image_run_opt}} \
{%- if '--log-driver=json-file' in docker_image_run_opt or '--log-driver' not in docker_image_run_opt %}
Expand Down
8 changes: 4 additions & 4 deletions files/scripts/syncd.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,14 @@ function wait_for_database_service()

function getBootType()
Copy link
Collaborator

@qiluo-msft qiluo-msft Jun 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getBootType [](start = 9, length = 11)

Can we reuse the function in /usr/bin/syncd.sh? If not, make sure you share the exactly same code snippet, add code comments referring each other so we will not modify one without the other in future by mistake. #Closed

{
case "$(cat /proc/cmdline | grep -o 'SONIC_BOOT_TYPE=\S*' | cut -d'=' -f2)" in
warm*)
case "$(cat /proc/cmdline)" in
*warm*)
TYPE='warm'
;;
fastfast)
*fastfast*)
TYPE='fastfast'
;;
fast*)
*fast*)
TYPE='fast'
;;
*)
Expand Down