-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marvell hwsku ET6448M 48x1G+4x10G Arm32 Mgmt switch #3221
Conversation
48x1G and 4x10G Management switch Signed-off-by: Antony Rheneus <arheneus@marvell.com>
Signed-off-by: Antony Rheneus <arheneus@marvell.com>
Signed-off-by: Antony Rheneus <arheneus@marvell.com>
@@ -0,0 +1 @@ | |||
switchMacAddress=00:50:43:ee:ee:ee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it mean all switches will have the same mac?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, but Hardware doesn't have board eeprom, so its been updated in config file. Need to be updated per board.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not quite understand the logic here, the mac address should be embedded in your board, we should not put a file in the image because then every image will be different for each board. but, I will let you address this problem later.
can you remove config_db.json and init_cfg.json, they are not needed in the image. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as comments
Is it end user's responsibility to generate config_db.json? |
Signed-off-by: Antony Rheneus <arheneus@marvell.com>
Done, removed json files |
Signed-off-by: Antony Rheneus <arheneus@marvell.com>
can you update your pr title to be more specific? |
Done |
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)