[Mellanox]enhance the initialization flow of sfp part of new platform api #3319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keboliu
approved these changes
Aug 14, 2019
platform/mellanox/mlnx-platform-api/sonic_platform/sfp_event.py
Outdated
Show resolved
Hide resolved
nazariig
reviewed
Aug 19, 2019
platform/mellanox/mlnx-platform-api/sonic_platform/sfp_event.py
Outdated
Show resolved
Hide resolved
nazariig
reviewed
Aug 19, 2019
platform/mellanox/mlnx-platform-api/sonic_platform/sfp_event.py
Outdated
Show resolved
Hide resolved
nazariig
approved these changes
Sep 25, 2019
andriymoroz-mlnx
approved these changes
Sep 25, 2019
jleveque
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Port mlnx-sfpd init flow enhancement #3294 to sfp_event.
On Mellanox devices sfp module insertion/removal is monitored via sdk notification.
Originally this is done in mlnx-sfpd task which is running in syncd.
In new platform api it is done directly in the chassis.get_change_event which runs in pmon and talks to sdk directly so that the optimization should be ported to new plaform api.
- How I did it
Port to new platform api
- How to verify it
Test sfp insert/remove flow.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)