start bgp_eoiu_mark service to populate bgp eoiu marker flags for warm start, if configured so #3489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dockers/docker-fpm-frr/start.sh
Outdated
| @@ -31,6 +31,11 @@ rm -f /var/run/rsyslogd.pid | |||
|
|
|||
| supervisorctl start rsyslogd | |||
|
|
|||
| # start eoiu pulling, only if configured so | |||
| if [ $(sonic-cfggen -d --print-data | grep 'bgp_eoiu' | grep -c 'true') -ge 1 ]; then | |||
There was a problem hiding this comment.
sonic-cfggen -d -v bgp_eoiu could work better here
There was a problem hiding this comment.
Hi Pavel, thanks for your review. However, "sonic-cfggen -d -v" doesn't seem to do the desired check:
admin@ASW-7004:$ sonic-cfggen -d --print-data | grep 'bgp_eoiu'
"bgp_eoiu": "true", <------- show the config
admin@ASW-7004:$ sonic-cfggen -d -v bgp_eoiu
<------- show nothing
admin@ASW-7004:$ sonic-cfggen -d -v 'WARM_RESTART'
{'bgp': {'bgp_eoiu': 'true', 'bgp_timer': '120'}}
admin@ASW-7004:$
There was a problem hiding this comment.
Try
sonic-cfggen -d -v 'WARM_RESTART.bgp.bgp_eoiu'
There was a problem hiding this comment.
I just updated the diff. Please review it. thanks
There was a problem hiding this comment.
if [ $(sonic-cfggen -d -v 'WARM_RESTART.bgp.bgp_eoiu' | grep -c 'true')
to
if [ $(sonic-cfggen -d -v 'WARM_RESTART.bgp.bgp_eoiu') = 'true' ];
or
if [[ $(sonic-cfggen -d -v 'WARM_RESTART.bgp.bgp_eoiu') == 'true' ]];
pavel-shirshov
approved these changes
Nov 6, 2019
prsunny
reviewed
Nov 14, 2019
| supervisorctl start bgp_eoiu_marker | ||
| fi | ||
|
|
||
| supervisorctl start bgpcfgd |
There was a problem hiding this comment.
Looks like this is added accidently? It was moved to end as part of #3627
zhenggen-xu
pushed a commit
to zhenggen-xu/sonic-buildimage
that referenced
this pull request
Jan 10, 2020
…m start, if configured so (sonic-net#3489) * start bgp_eoiu_mark service to populate bgp eoiu marker if configured so * Address code review comments: check db value via "-v" option in sonic-cfggen * Address code review comment 2: check string against 'true' directly, instead of couting * Update start.sh
mssonicbld
added a commit
that referenced
this pull request
Sep 7, 2024
…atically (#20188) #### Why I did it src/sonic-utilities ``` * 3a0575c2 - (HEAD -> 202405, origin/202405) Add back the option f to the reboot script (#3492) (4 hours ago) [DavidZagury] * 60c14df8 - Enable show interfacess counters on chassis supervisor (#3488) (4 hours ago) [Changrong Wu] * cbbfe7b7 - [chassis][cli] Fix config chassis module startup/shutdown command for fabric module (#3483) (4 hours ago) [Marty Y. Lok] * b6cbe6ed - Remove redundant mmuconfig file (#3446) (4 hours ago) [HP] * fb6dd589 - [qos reload] Fix "config qos reload" overriding entire CONFIG_DB (#3479) (4 hours ago) [Stepan Blyshchak] * 9da5db58 - Skip default lanes dup check (#3489) (4 hours ago) [Xincun Li] * edde02ce - [Mellanox] Add CMIS Host Management Files to 'show techsupport' Dumps (#3501) (4 hours ago) [Tomer Shalvi] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address review comments for
#2823
Other related PR:
sonic-net/sonic-utilities#655
#2823
sonic-net/sonic-swss-common#273
sonic-net/sonic-swss#856