Add daemon which periodically pushes process and docker stats to State DB #3525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
suggested changes
Sep 27, 2019
jleveque
suggested changes
Sep 30, 2019
jleveque
suggested changes
Oct 2, 2019
jleveque
suggested changes
Oct 5, 2019
jleveque
suggested changes
Oct 25, 2019
hui-ma
reviewed
Oct 25, 2019
|
Some questions: |
|
@hui-ma: For the daemon to get included in the image and started automatically, Pradnya will need to add it to files/build_templates/sonic_debian_extension.j2. To have the daemon auto-restart upon crash, she will need to add the line |
|
@jleveque Thanks for the info of files/build_templates/sonic_debian_extension.j2.. Let us do another PR for it later. |
|
@hui-ma: I believe that change should be part of this PR. It is a small change, and I can help Pradnya. |
jleveque
suggested changes
Nov 13, 2019
jleveque
suggested changes
Nov 13, 2019
adding more descriptive names line indented returning explicitly none
jleveque
suggested changes
Nov 14, 2019
changed comment for daemon
jleveque
suggested changes
Nov 14, 2019
jleveque
reviewed
Nov 14, 2019
jleveque
suggested changes
Nov 14, 2019
jleveque
suggested changes
Nov 14, 2019
rearrange imports based on comment
jleveque
suggested changes
Nov 14, 2019
jleveque
suggested changes
Nov 16, 2019
jleveque
suggested changes
Nov 21, 2019
done |
jleveque
suggested changes
Nov 21, 2019
hui-ma
approved these changes
Nov 22, 2019
|
Retest broadcom please |
jleveque
suggested changes
Nov 26, 2019
jleveque
suggested changes
Nov 26, 2019
adding process/docker in comment
jleveque
approved these changes
Nov 27, 2019
|
Retest vs please |
|
Retest vsimage please |
jleveque
changed the title
|
vsimage check build failure is unrelated. Merging PR in spite of this failure. |
zhenggen-xu
pushed a commit
to zhenggen-xu/sonic-buildimage
that referenced
this pull request
Jan 10, 2020
mssonicbld
added a commit
that referenced
this pull request
Sep 11, 2024
…atically (#20202) #### Why I did it src/sonic-utilities ``` * a7897d1f - (HEAD -> master, origin/master, origin/HEAD) [show][interface][counters] Add proposal and changes for fec-histogram for interface counters fec-histogram subcommand (#3519) (10 hours ago) [vdahiya12] * 5fdc1b61 - [Mellanox] Add new SKU Mellanox-SN5600-C256 (#3431) (34 hours ago) [DavidZagury] * d103bfd7 - Fix ntp conf file path (#3525) (34 hours ago) [Vivek] * 5eb266ac - [chassis] Modify the show ip route to hide the Ethernet-IB port in the output (#3537) (34 hours ago) [Arvindsrinivasan Lakshmi Narasimhan] ``` #### How I did it #### How to verify it #### Description for the changelog
vvolam
pushed a commit
to vvolam/sonic-buildimage
that referenced
this pull request
Sep 12, 2024
…atically (sonic-net#20202) #### Why I did it src/sonic-utilities ``` * a7897d1f - (HEAD -> master, origin/master, origin/HEAD) [show][interface][counters] Add proposal and changes for fec-histogram for interface counters fec-histogram subcommand (sonic-net#3519) (10 hours ago) [vdahiya12] * 5fdc1b61 - [Mellanox] Add new SKU Mellanox-SN5600-C256 (sonic-net#3431) (34 hours ago) [DavidZagury] * d103bfd7 - Fix ntp conf file path (sonic-net#3525) (34 hours ago) [Vivek] * 5eb266ac - [chassis] Modify the show ip route to hide the Ethernet-IB port in the output (sonic-net#3537) (34 hours ago) [Arvindsrinivasan Lakshmi Narasimhan] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Adding daemon which every 2 mins uploads docker and process stats data to state db
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)