Fpga crash fix #3672
Merged
Fpga crash fix #3672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest vs please |
srideepDell
approved these changes
Oct 31, 2019
lguohan
approved these changes
Nov 5, 2019
mssonicbld
added a commit
that referenced
this pull request
Dec 23, 2024
…atically (#21194) #### Why I did it src/sonic-utilities ``` * 2f8508f1 - (HEAD -> master, origin/master, origin/HEAD) Revert PR: Add scope to field validator (#3689) (3 days ago) [xwjiang-ms] * 5481d0ef - Optimize techsupport reducing number of vtysh calls in scale sceario (#3605) (5 days ago) [Sudharsan Dhamal Gopalarathnam] * 7e2e59c5 - add sonic_asic_platform in the render context when rendering docker_image_ctl.j2 (#3672) (5 days ago) [Changrong Wu] * d85e1db3 - Disable routeCheck monit as part of config reload/minigraph stop service and enable it back as part of service start. (#3682) (6 days ago) [abdosi] * 139983ad - platform/marvell renaming to platform/marvell-prestera (#3622) (6 days ago) [krismarvell] * e3991d54 - Add scope to field validator. (#3675) (7 days ago) [Xincun Li] ``` #### How I did it #### How to verify it #### Description for the changelog
github-actions bot
pushed a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Jan 2, 2025
…atically (sonic-net#21194) #### Why I did it src/sonic-utilities ``` * 2f8508f1 - (HEAD -> master, origin/master, origin/HEAD) Revert PR: Add scope to field validator (sonic-net#3689) (3 days ago) [xwjiang-ms] * 5481d0ef - Optimize techsupport reducing number of vtysh calls in scale sceario (sonic-net#3605) (5 days ago) [Sudharsan Dhamal Gopalarathnam] * 7e2e59c5 - add sonic_asic_platform in the render context when rendering docker_image_ctl.j2 (sonic-net#3672) (5 days ago) [Changrong Wu] * d85e1db3 - Disable routeCheck monit as part of config reload/minigraph stop service and enable it back as part of service start. (sonic-net#3682) (6 days ago) [abdosi] * 139983ad - platform/marvell renaming to platform/marvell-prestera (sonic-net#3622) (6 days ago) [krismarvell] * e3991d54 - Add scope to field validator. (sonic-net#3675) (7 days ago) [Xincun Li] ``` #### How I did it #### How to verify it #### Description for the changelog
github-actions bot
pushed a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Jan 2, 2025
…atically (sonic-net#21194) #### Why I did it src/sonic-utilities ``` * 2f8508f1 - (HEAD -> master, origin/master, origin/HEAD) Revert PR: Add scope to field validator (sonic-net#3689) (3 days ago) [xwjiang-ms] * 5481d0ef - Optimize techsupport reducing number of vtysh calls in scale sceario (sonic-net#3605) (5 days ago) [Sudharsan Dhamal Gopalarathnam] * 7e2e59c5 - add sonic_asic_platform in the render context when rendering docker_image_ctl.j2 (sonic-net#3672) (5 days ago) [Changrong Wu] * d85e1db3 - Disable routeCheck monit as part of config reload/minigraph stop service and enable it back as part of service start. (sonic-net#3682) (6 days ago) [abdosi] * 139983ad - platform/marvell renaming to platform/marvell-prestera (sonic-net#3622) (6 days ago) [krismarvell] * e3991d54 - Add scope to field validator. (sonic-net#3675) (7 days ago) [Xincun Li] ``` #### How I did it #### How to verify it #### Description for the changelog
github-actions bot
pushed a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Jan 2, 2025
…atically (sonic-net#21194) #### Why I did it src/sonic-utilities ``` * 2f8508f1 - (HEAD -> master, origin/master, origin/HEAD) Revert PR: Add scope to field validator (sonic-net#3689) (3 days ago) [xwjiang-ms] * 5481d0ef - Optimize techsupport reducing number of vtysh calls in scale sceario (sonic-net#3605) (5 days ago) [Sudharsan Dhamal Gopalarathnam] * 7e2e59c5 - add sonic_asic_platform in the render context when rendering docker_image_ctl.j2 (sonic-net#3672) (5 days ago) [Changrong Wu] * d85e1db3 - Disable routeCheck monit as part of config reload/minigraph stop service and enable it back as part of service start. (sonic-net#3682) (6 days ago) [abdosi] * 139983ad - platform/marvell renaming to platform/marvell-prestera (sonic-net#3622) (6 days ago) [krismarvell] * e3991d54 - Add scope to field validator. (sonic-net#3675) (7 days ago) [Xincun Li] ``` #### How I did it #### How to verify it #### Description for the changelog
VladimirKuk
pushed a commit
to Marvell-switching/sonic-buildimage
that referenced
this pull request
Jan 21, 2025
…atically (sonic-net#21194) #### Why I did it src/sonic-utilities ``` * 2f8508f1 - (HEAD -> master, origin/master, origin/HEAD) Revert PR: Add scope to field validator (sonic-net#3689) (3 days ago) [xwjiang-ms] * 5481d0ef - Optimize techsupport reducing number of vtysh calls in scale sceario (sonic-net#3605) (5 days ago) [Sudharsan Dhamal Gopalarathnam] * 7e2e59c5 - add sonic_asic_platform in the render context when rendering docker_image_ctl.j2 (sonic-net#3672) (5 days ago) [Changrong Wu] * d85e1db3 - Disable routeCheck monit as part of config reload/minigraph stop service and enable it back as part of service start. (sonic-net#3682) (6 days ago) [abdosi] * 139983ad - platform/marvell renaming to platform/marvell-prestera (sonic-net#3622) (6 days ago) [krismarvell] * e3991d54 - Add scope to field validator. (sonic-net#3675) (7 days ago) [Xincun Li] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fixed the fpga crash issue which we see in 15-20 mins time frame after onie-install. - crash_trace.txt
crash_trace.txt.txt
- How I did it
This new state STATE_STOP will not be exposed for the wake up call till all the ISR of previous transfer is completed successfully.Accessing stale i2c transfer message buffer causes this crash. Te message buffer becomes stale due to race between i2c transfer and fpga interrupt handler.
- How to verify it
Verified by running many iterations of onie-uninstall and onie-install where we saw crash before fix for once in 3 iterations. - session_logs.txt
- Description for the changelog
session_logs.txt