Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docker-fpm-frr]: Refactor bgpcfgd #3789

Merged
merged 1 commit into from
Nov 22, 2019
Merged

[docker-fpm-frr]: Refactor bgpcfgd #3789

merged 1 commit into from
Nov 22, 2019

Conversation

pavel-shirshov
Copy link
Contributor

- What I did
Refactor bgpcfgd to make extension of it simpler.

- How I did it

  1. Implement class Directory, which:
  • store all state
  • allows to subscribe on changes
  1. Extract class Manager, which implement base functionality of managers
  2. Introduce 3 managers

- How to verify it

  1. Put bgpcfgd from the PR instead of your dut bgpcfgd and restart dut

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@pavel-shirshov pavel-shirshov self-assigned this Nov 20, 2019
@lguohan
Copy link
Collaborator

lguohan commented Nov 22, 2019

LGTM

@pavel-shirshov pavel-shirshov merged commit a73eb66 into sonic-net:master Nov 22, 2019
@pavel-shirshov pavel-shirshov deleted the pavelsh/new_bgpcfgd branch November 22, 2019 19:07
zhenggen-xu pushed a commit to zhenggen-xu/sonic-buildimage that referenced this pull request Jan 10, 2020
@pavel-shirshov @zhenggen-xu
[docker-fpm-frr]: Refactor bgpcfgd (sonic-net#3789)
1b176f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

@tameraw tameraw Awaiting requested review from tameraw

Assignees

@pavel-shirshov pavel-shirshov

Labels
Enhancement ➕
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavel-shirshov @lguohan