[swss.sh] When starting, call 'systemctl restart' on dependents, not 'systemctl start' #3807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'systemctl start'
jleveque
requested review from
renukamanavalan and
a-santamaria
and removed request for
a-santamaria
yxieca
approved these changes
Nov 23, 2019
zhenggen-xu
pushed a commit
to zhenggen-xu/sonic-buildimage
that referenced
this pull request
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
When SwSS starts in non-warm-boot mode, it also starts its dependent services (currently radv and teamd). Previously, it did so by calling
systemctl start. However, in the case that the dependent services had not previously been stopped,systemctl startwould basically become a no-op, as it would see the service(s) were already started and do nothing. However, the expected behavior is for the dependent services to start anew, thus this patch changes the behavior to callingsystemctl restart, which will first stop the dependent services if they are already running, then start them.