Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[swsssdk-py] submodule update for sonic-py-swsssdk #3929

Merged
merged 1 commit into from
Dec 27, 2019

Conversation

dzhangalibaba
Copy link
Collaborator

update multiDB changes in sonic-py-swsssdk, including:

PR #3928 needs this swsssdk-py changes to work

Signed-off-by: Dong Zhang d.zhang@alibaba-inc.com

Copy link
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems to have issues. It have picked up a lot of extra commits. Can you try rebasing?

@dzhangalibaba
Copy link
Collaborator Author

since master branch did some revert, rebase master and resubmit the PR

@dzhangalibaba dzhangalibaba reopened this Dec 22, 2019
@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

2 similar comments
@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

@lguohan lguohan dismissed jleveque’s stale review December 27, 2019 17:30

pr has been rebased

@lguohan lguohan merged commit 86ab2ae into sonic-net:master Dec 27, 2019
@dzhangalibaba dzhangalibaba deleted the subswsssdk branch January 2, 2020 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants