Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kdump support for arm, as the dependency with uboot, skipping kdump installation on ARM #3962

Merged
merged 2 commits into from
Jan 29, 2020

Conversation

banagiri
Copy link
Contributor

@banagiri banagiri commented Jan 2, 2020

as the dependency with uboot, skipping kdump installation on ARM

** skipping kdump installation on ARM platforms**

SONIC compilation for arm arch

compile SONIC for ARM arch

- Description for the changelog
as the current kdump installation is searching for grub path, and ARM arch (marvell-armhf) are dependent on uboot, these changes has to be addressed

@lguohan
Copy link
Collaborator

lguohan commented Jan 16, 2020

how do we plan to enable it?

@banagiri
Copy link
Contributor Author

++@antony-rheneus

@antony-rheneus
Copy link
Contributor

how do we plan to enable it?

Issue is in the kdump post installation scripts of debian package, which check for grub.conf.
We will be revisiting this change once we fix the kdump package source post installation script to work with uboot env firmware

@lguohan
Copy link
Collaborator

lguohan commented Jan 24, 2020

retest this please

@lguohan
Copy link
Collaborator

lguohan commented Jan 24, 2020

retest this please

@banagiri
Copy link
Contributor Author

retest this please

@lguohan this has been tested successfully

@jleveque
Copy link
Contributor

@banagiri: That comment wasn't directed at you. By entering the phrase "retest this please" into a comment, GitHub triggers our Jenkins instance to re-run all of the check builds.

@banagiri
Copy link
Contributor Author

@jleveque

Understood. But it's bit confusing to whom the sentence was ment.
Can we add @jenkins retest this please

@jleveque
Copy link
Contributor

@banagiri: I completely agree that it is confusing. However, that phrase is coded into a third-party Jenkins plugin which we use, and to the best of my knowledge it is not customizable. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants