Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monit] Change the full process name of syncd in the monit config file. #4033

Merged
merged 9 commits into from
Jan 23, 2020
Merged

[Monit] Change the full process name of syncd in the monit config file. #4033

merged 9 commits into from
Jan 23, 2020

Conversation

yozhao101
Copy link
Contributor

- What I did
Since the syncd process running on different platforms will have the different full path names, we
change the full path name of process syncd in the monit config file such that it will be universal and is
not for a specific vendor.

- How I did it

- How to verify it

such that this name is universal for all platforms not specific for a vendor.

Signed-off-by: Yong Zhao <yozhao@microsoft.com>
such that it is universal not specific for a vendor.

Signed-off-by: Yong Zhao <yozhao@microsoft.com>
…fig file

such that it is universal.

Signed-off-by: Yong Zhao <yozhao@microsoft.com>
such that it is universal for all the platforms.

Signed-off-by: Yong Zhao <yozhao@microsoft.com>
file such that it is universal for all platforms.

Signed-off-by: Yong Zhao <yozhao@microsoft.com>
that it is universal for all platforms.

Signed-off-by: Yong Zhao <yozhao@microsoft.com>
file such that it is universal for all platforms.

Signed-off-by: Yong Zhao <yozhao@microsoft.com>
file such that it is universal for all the platforms.

Signed-off-by: Yong Zhao <yozhao@microsoft.com>
file such that it is universal for all platforms.

Signed-off-by: Yong Zhao <yozhao@microsoft.com>
@yozhao101 yozhao101 requested a review from jleveque January 16, 2020 22:15
@vsenchyshyn
Copy link
Contributor

@yozhao101 Could we also lower the log level about telemetry not running to WARN in order to make the tests which are sensitive to errors in log passing? As telemetry gets always crashed and no one cares about this why do we treat this process as critical one?

@jleveque
Copy link
Contributor

Retest broadcom please

@jleveque
Copy link
Contributor

Retest vs please

@jleveque
Copy link
Contributor

Retest mellanox please

@lguohan lguohan merged commit db76686 into sonic-net:master Jan 23, 2020
yxieca pushed a commit that referenced this pull request Jan 23, 2020
…e. (#4033)

Since the syncd process running on different platforms will have the different full path names, we
change the full path name of process syncd in the monit config file such that it will be universal and is not for a specific vendor.

Signed-off-by: Yong Zhao <yozhao@microsoft.com>
abdosi pushed a commit that referenced this pull request Feb 4, 2020
…e. (#4033)

Since the syncd process running on different platforms will have the different full path names, we
change the full path name of process syncd in the monit config file such that it will be universal and is not for a specific vendor.

Signed-off-by: Yong Zhao <yozhao@microsoft.com>
pphuchar pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Mar 9, 2020
…e. (sonic-net#4033)

Since the syncd process running on different platforms will have the different full path names, we
change the full path name of process syncd in the monit config file such that it will be universal and is not for a specific vendor.

Signed-off-by: Yong Zhao <yozhao@microsoft.com>
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 24, 2020
…e. (sonic-net#4033)

Since the syncd process running on different platforms will have the different full path names, we
change the full path name of process syncd in the monit config file such that it will be universal and is not for a specific vendor.

Signed-off-by: Yong Zhao <yozhao@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants