-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monit] Change the full process name of syncd in the monit config file. #4033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
such that this name is universal for all platforms not specific for a vendor. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
such that it is universal not specific for a vendor. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
…fig file such that it is universal. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
such that it is universal for all the platforms. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
file such that it is universal for all platforms. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
that it is universal for all platforms. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
file such that it is universal for all platforms. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
file such that it is universal for all the platforms. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
file such that it is universal for all platforms. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
jleveque
approved these changes
Jan 17, 2020
@yozhao101 Could we also lower the log level about telemetry not running to WARN in order to make the tests which are sensitive to errors in log passing? As telemetry gets always crashed and no one cares about this why do we treat this process as critical one? |
Retest broadcom please |
Retest vs please |
Retest mellanox please |
yxieca
pushed a commit
that referenced
this pull request
Jan 23, 2020
…e. (#4033) Since the syncd process running on different platforms will have the different full path names, we change the full path name of process syncd in the monit config file such that it will be universal and is not for a specific vendor. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
abdosi
pushed a commit
that referenced
this pull request
Feb 4, 2020
…e. (#4033) Since the syncd process running on different platforms will have the different full path names, we change the full path name of process syncd in the monit config file such that it will be universal and is not for a specific vendor. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
pphuchar
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Mar 9, 2020
…e. (sonic-net#4033) Since the syncd process running on different platforms will have the different full path names, we change the full path name of process syncd in the monit config file such that it will be universal and is not for a specific vendor. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 24, 2020
…e. (sonic-net#4033) Since the syncd process running on different platforms will have the different full path names, we change the full path name of process syncd in the monit config file such that it will be universal and is not for a specific vendor. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Since the syncd process running on different platforms will have the different full path names, we
change the full path name of process syncd in the monit config file such that it will be universal and is
not for a specific vendor.
- How I did it
- How to verify it