-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove minlink initial value while fallback is define #4090
Open
twtseng-tim
wants to merge
2
commits into
sonic-net:master
Choose a base branch
from
twtseng-tim:fix_fallback
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenkelly
previously approved these changes
Feb 7, 2020
pavel-shirshov
suggested changes
May 18, 2020
@@ -221,7 +221,7 @@ def parse_dpg(dpg, hname): | |||
intfs_inpc.append(pcmbr_list[i]) | |||
pc_members[(pcintfname, pcmbr_list[i])] = {'NULL': 'NULL'} | |||
if pcintf.find(str(QName(ns, "Fallback"))) != None: | |||
pcs[pcintfname] = {'members': pcmbr_list, 'fallback': pcintf.find(str(QName(ns, "Fallback"))).text, 'min_links': str(int(math.ceil(len() * 0.75)))} | |||
pcs[pcintfname] = {'members': pcmbr_list, 'fallback': pcintf.find(str(QName(ns, "Fallback"))).text} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should put pcmbr_list
as len parameter here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see here #2053 (comment) decided to remove this parameter
fallback support multi-member now?
pavel-shirshov
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
remove minlink initial value while fallback is define [#2053]
- How I did it
- How to verify it
add
<Fallback>true</Fallback>
in minigraph.xml where defined PortchannelDo:
config load_minigraph -y
- Description for the changelog
before this change I got following error message:
after this change it can load normally: