Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made Change to have Configurable option to enable/disable docker image #4171

Merged
merged 3 commits into from
Feb 21, 2020

Conversation

abdosi
Copy link
Contributor

@abdosi abdosi commented Feb 20, 2020

Made Change to have Configurable option to enable/disable docker image.
Also update sonic-utilities submodule to latest. Needed PR#815 of sonic-utilities to make service start/stop/reset happen correctly if we enable/disable docker creation.

- What I did

Add Build Flag to Enable/disable nat docker image creation.

- How I did it
updated rule/configure.

- How to verify it

verified nat docker image creation when flag is y
verified nat docker not created when flag is n

- Description of changelog
[sonic-utilities] submodule update
ea374a7 - Akhilesh Samineni, 11 hours ago : Fix for dhcp_relay deletion on a VLAN (#813)
fa21372 - abdosi, 11 hours ago : Added check if service existis before start/stop/restart of service. (#815)
caa2773 - Oleksandr Kuzovych, 18 hours ago : [config] Add 'config interface mtu' command (#793)
659a935 - Nazarii Hnydyn, 32 hours ago : [fwutil]: Command-line utility for interacting with platform components (#772)
c45ad99 - yozhao101, 8 days ago : [config/main.py] Modify reload() function to load configuration from init_cfg.json implicitly (#812)
a4385f0 - rajendra-dendukuri, 9 days ago : ZTP CLI commands (#599)
3d794cc - yozhao101, 11 days ago : [Command Reference] Correct a typo and fix link jump in the section container auto-restart feature. (#808)
15e5fab - yozhao101, 2 weeks ago : [Command Reference] Document CLI commands related to container auto-restart feature (#802)
53f8904 - yozhao101, 2 weeks ago : [config] Add subcommand to configure the status of auto-restart feature for each container (#801)
bb10686 - yozhao101, 2 weeks ago : [show] Add subcommand to display the status of auto-restart feature for each container (#798)
1fc2c3d - borys-karpliak, 2 weeks ago : Fix 'show platform eeprom' on virtual switch (#794)
34b5819 - Dong Zhang, 3 weeks ago : [MultiDB] refactor docker warm reboot codes (#799)
a078c42 - heidinet2007, 3 weeks ago : Add document for warm restart use case (#720)
89e6361 - lguohan, 3 weeks ago : [showtech]: dump a few more DB in generate dump (#795)
6b23f19 - Guohan Lu, 3 weeks ago : Changes in swss-utilities submodule to support NAT feature. (#645)

rlhui
rlhui previously approved these changes Feb 20, 2020
@abdosi
Copy link
Contributor Author

abdosi commented Feb 21, 2020

Retest this please

@abdosi abdosi merged commit f5ab24d into sonic-net:master Feb 21, 2020
@abdosi abdosi deleted the natMakeConfig branch February 21, 2020 18:20
abdosi added a commit that referenced this pull request Feb 24, 2020
#4171)

* Made Change to have Configurable option to enable/disable docker image

* [Submodule-Update] sonic-utilities .
Following PR has been merged tp 201911
* Platform Driver Development Framework (PDDF): Adding PDDF CLI utils
* [config] Add 'feature' subcommand
* [fwutil]: Command-line utility for interacting with platform components
* [show] Add subcommand to display the status of auto-restart feature
                                                for each container
* [config] Add subcommand to configure the status of auto-restart
                                                feature for each
                                                container
* [Command Reference] Document CLI commands related to container
                                                auto-restart feature
* [config/main.py] Modify reload() function to load configuration from
                                                init_cfg.json
* Fix for dhcp_relay deletion on a VLAN
* [config] Check if service exists before start/stop/restart of service
* Multi-Db changes for NAT feature
* [reboot] make sure the reboot happens even if platform reboot failed
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request Feb 26, 2020
sonic-net#4171)

* Made Change to have Configurable option to enable/disable docker image

* [Submodule-Update] sonic-utilities to latest master
pphuchar pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Mar 9, 2020
sonic-net#4171)

* Made Change to have Configurable option to enable/disable docker image

* [Submodule-Update] sonic-utilities .
Following PR has been merged tp 201911
* Platform Driver Development Framework (PDDF): Adding PDDF CLI utils
* [config] Add 'feature' subcommand
* [fwutil]: Command-line utility for interacting with platform components
* [show] Add subcommand to display the status of auto-restart feature
                                                for each container
* [config] Add subcommand to configure the status of auto-restart
                                                feature for each
                                                container
* [Command Reference] Document CLI commands related to container
                                                auto-restart feature
* [config/main.py] Modify reload() function to load configuration from
                                                init_cfg.json
* Fix for dhcp_relay deletion on a VLAN
* [config] Check if service exists before start/stop/restart of service
* Multi-Db changes for NAT feature
* [reboot] make sure the reboot happens even if platform reboot failed
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 24, 2020
sonic-net#4171)

* Made Change to have Configurable option to enable/disable docker image

* [Submodule-Update] sonic-utilities .
Following PR has been merged tp 201911
* Platform Driver Development Framework (PDDF): Adding PDDF CLI utils
* [config] Add 'feature' subcommand
* [fwutil]: Command-line utility for interacting with platform components
* [show] Add subcommand to display the status of auto-restart feature
                                                for each container
* [config] Add subcommand to configure the status of auto-restart
                                                feature for each
                                                container
* [Command Reference] Document CLI commands related to container
                                                auto-restart feature
* [config/main.py] Modify reload() function to load configuration from
                                                init_cfg.json
* Fix for dhcp_relay deletion on a VLAN
* [config] Check if service exists before start/stop/restart of service
* Multi-Db changes for NAT feature
* [reboot] make sure the reboot happens even if platform reboot failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants