Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MultiDB] : add persistence field for each redis instance #4254

Merged
merged 2 commits into from
Apr 8, 2020
Merged

[MultiDB] : add persistence field for each redis instance #4254

merged 2 commits into from
Apr 8, 2020

Conversation

dzhangalibaba
Copy link
Collaborator

  • add "persistence" field for each redis instance in database_config.json
  • we will use this information to decide if saving redis instance data while warm/fast reboot
    • before multiDB changes, SONiC uses "redis-cli save " to save all the data into rdb file on default instance on port 6379
    • with multiDB changes, we plan to implement "sonic-db-cli save" to save all data to corresponding rdb files on all listed redis instances which has "persistence" field set "yes"

Signed-off-by: Dong Zhang d.zhang@alibaba-inc.com

@dzhangalibaba
Copy link
Collaborator Author

@qiluo-msft please check with @lguohan this design is OK to go or not

@qiluo-msft qiluo-msft requested a review from lguohan March 11, 2020 21:28
@qiluo-msft
Copy link
Collaborator

Looks good to me

@dzhangalibaba
Copy link
Collaborator Author

retest this please

@lguohan
Copy link
Collaborator

lguohan commented Mar 22, 2020

retest vs please

@lguohan
Copy link
Collaborator

lguohan commented Mar 22, 2020

retest vsimage please

@dzhangalibaba
Copy link
Collaborator Author

@qiluo could we merge this , then I can start next based on this design.

@qiluo-msft
Copy link
Collaborator

@lguohan do you have more concerns?

qiluo-msft
qiluo-msft previously approved these changes Apr 6, 2020
View reviewed changes
@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

1 similar comment
@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

@lguohan lguohan merged commit de5a04a into sonic-net:master Apr 8, 2020
@dzhangalibaba dzhangalibaba deleted the multi-db branch April 14, 2020 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan left review comments

@qiluo-msft qiluo-msft qiluo-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dzhangalibaba @qiluo-msft @lguohan