Failed to create Broadcom RPC "syncd" container due to the duplicated "--net" options in the docker create command #4296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fix the error that Broadcom RPC syncd container cannot be created.
When starting the Broadcom RPC syncd container, the container cannot be created successfully. It is found the error messages shown below show up in the syslog.
- How I did it
The content shown below is excerpted from the file "usr/bin/syncd.sh" on the DUT(i.e. AS7326-56X).
It is found that there are two "--net" options for the "docker create" command which results in the failure.
In the file "files/build_templates/docker_image_ctl.j2", it adds the option
"--net" to the docker create command through the commit
"abe7ef7e2e2e1215c97cee19a83aab0b130cebe5" (#3856).
Remove the "--net" option in "docker-syncd-brcm-rpc.mk" to avoid
specifying duplicated "--net" options.
- How to verify it
After applying the commit in this PR, execute "make target/sonic-broadcom.bin ENABLE_SYNCD_RPC=y" to build the sonic image which contains "rpc" syncd. Install the sonic image on the AS7326-56X and observe whether the "syncd" container can be created without error.
- Description for the changelog
Remove the "--net" option in "docker-syncd-brcm-rpc.mk" to avoid
specifying duplicated "--net" options.
- A picture of a cute animal (not mandatory but encouraged)