Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[interfaces]: Restart networking service after the file is updated #430

Merged
merged 1 commit into from
Mar 23, 2017
Merged

Conversation

stcheng
Copy link
Contributor

@stcheng stcheng commented Mar 23, 2017

Signed-off-by: Shuotian Cheng shuche@microsoft.com

Signed-off-by: Shuotian Cheng <shuche@microsoft.com>
@stcheng stcheng requested review from jleveque and taoyl-ms March 23, 2017 19:45
@stcheng stcheng self-assigned this Mar 23, 2017
ifdown eth0 && ifup eth0
ifdown lo && ifup lo

service networking restart
Copy link
Contributor

@jleveque jleveque Mar 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious if we prefer to use service networking restart or systemctl restart networking. Either way, we should choose one method and stick with it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think they are here doing the same thing. is systemctl newer than service command? I could switch to systemctl.

Copy link
Contributor

@jleveque jleveque Mar 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they do the same thing. systemctl is part of systemd, whereas service has been around awhile and has been made to wrap a few different service managers.

@jleveque
Copy link
Contributor

jleveque commented Mar 23, 2017

Cavium build failed due to no space left on devic. I think this is good to merge.

@stcheng stcheng merged commit 5150ed5 into sonic-net:master Mar 23, 2017
@stcheng stcheng deleted the intfs branch March 23, 2017 23:30
@jleveque
Copy link
Contributor

Just adding a note that this change was implemented in order to make sure Vlans are brought up on boot.

lguohan pushed a commit that referenced this pull request Apr 12, 2019
…2755)

sonic-sairedis:
e8cb879 Make object list deterministic when iterating (#438)
5486f97 Ignore ACL_COUNTER bytes and packets during comparison logic (#443)
b138ff9 Notify OA about exception and process only restart query events (#437)
0974a43 Set MTU value on created tap device for virtual switch (#436)
e2f50e8 Increase eth buffer size to 16k for virtual switch (#435)
79fb388 [bfn] Ged rid of ld_preload. Link against libsai only (#429)
2e47b78 Remove MAC alignment WA for Mellanox platforms. (#430)
e1354fe Add pre match to comparison logic and unittests (#423)
18a5ebb Drop FDB notifications if they contain invalid OIDs (#428)

sonic-swss-common:
8af58ad sonic-swss-common: Add vxlan macros to schema (#269)
76837bf Make class Select support batch read from selectables (#270)
4cf643e Add multiple fields hdel support (#267)
a710529 Update PFC_WD table name in CONFIG_DB (#266)
3c452c1 Update README.md (#268)

sonic-swss:
e329dbd Survive pfc watchdog storm action across warm-reboot (#794)

sonic-utilities:
6ee0aea (HEAD, origin/master, origin/HEAD) [config]: Change the order of interface commands (#504)
5ae30d2 [show vlan brief] Support 'alias' interface naming mode (#497)
bafebf9 Update neighbor advertiser (#498)
fa90083 [clear/main.py]: clear ndp command. (#450)
65f69e4 [show interface neighbor expected] Support 'alias' interface naming mode (#495)
aae39e7 updated show ipv6 interface for alias mode (#493)
170fed9 [warm-reboot] initialize warm reboot state table before warm rebooting (#492)
06cd99f Allow config shutdown and startup operations on valid PortChannel interface names (#474)
98cdebb [show ip interface] Add support for 'alias' interface naming mode (#486)
5f1de81 [show] Add serial numbers/uptime/hwinfo to 'show version' output (#488)
e78a866 [route_check] Move scripts under scripts/ directory, add to setup.py (#489)
d347527 Change PFC watchdog CONFIG_DB table name from PFC_WD_TABLE to PFC_WD (#475)

Signed-off-by: Wenda Ni <wenni@microsoft.com>
dmytroxshevchuk pushed a commit to dmytroxshevchuk/sonic-buildimage that referenced this pull request Aug 31, 2020
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
lguohan pushed a commit that referenced this pull request Jan 1, 2021
Including commits in sonic-swss-common repo:

b423b9c Add support for hexists call (#432) [Tony Titus]
0982996 Remove extension of tableNameSeparatorMap (#430) [Qi Luo]
d16cc76 [build]: add azure pipeline build badge (#429) [lguohan]
f2aaf55 Set up CI with Azure Pipelines (#428) [lguohan]
mssonicbld added a commit that referenced this pull request Feb 26, 2024
…D automatically (#18174)

#### Why I did it
src/sonic-platform-daemons
```
* 9141305 - (HEAD -> master, origin/master, origin/HEAD) Enhance port_update_event logic to be thread-safe (#430) (3 days ago) [longhuan-cisco]
```
#### How I did it
#### How to verify it
#### Description for the changelog
sonic-otn pushed a commit to Weitang-Zheng/sonic-buildimage that referenced this pull request Mar 11, 2024
…D automatically (sonic-net#18174)

#### Why I did it
src/sonic-platform-daemons
```
* 9141305 - (HEAD -> master, origin/master, origin/HEAD) Enhance port_update_event logic to be thread-safe (sonic-net#430) (3 days ago) [longhuan-cisco]
```
#### How I did it
#### How to verify it
#### Description for the changelog
saksarav-nokia pushed a commit to saksarav-nokia/sonic-buildimage that referenced this pull request Mar 12, 2024
…D automatically (sonic-net#18174)

#### Why I did it
src/sonic-platform-daemons
```
* 9141305 - (HEAD -> master, origin/master, origin/HEAD) Enhance port_update_event logic to be thread-safe (sonic-net#430) (3 days ago) [longhuan-cisco]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants