[MultiDB] daemon base should use multiDB DBConnector #4549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR and sonic-net/sonic-platform-daemons#57 depends on each other, the submodule needs updated to sonic-net/sonic-platform-daemons#57 with the merge of this PR together. |
qiluo-msft
previously approved these changes
May 6, 2020
|
retest mellanox please |
|
qiluo-msft
approved these changes
Jun 5, 2020
|
retest mellanox please |
|
retest vsimage please |
|
retest mellanox please |
abdosi
added a commit
to abdosi/sonic-buildimage
that referenced
this pull request
Aug 15, 2020
a) we should use get_platform() with new sonic_py-common package b) In 201911 DB Connector is still using db id based constructor as following PR sonic-net#4549 is not cherry-picked yet. So revert the change to use db is insatead of db_name for now. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
abdosi
added a commit
that referenced
this pull request
Aug 15, 2020
a) we should use get_platform() with new sonic_py-common package b) In 201911 DB Connector is still using db id based constructor as following PR #4549 is not cherry-picked yet. So revert the change to use db is insatead of db_name for now. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should use new multiDB Connector in daemon base
When merging this this PR, need to make sure [MultiDB] should use multiDB API sonic-platform-daemons#57 is already updated to the latest.
update submodule in this PR as well to avoid dependency between [MultiDB] should use multiDB API sonic-platform-daemons#57 and this PR.
Signed-off-by: Dong Zhang d.zhang@alibaba-inc.com