Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker-orchagent]: Generate config-files for IPinIP and Everflow. #471

Closed
wants to merge 2 commits into from

Conversation

antonpatenko
Copy link
Contributor

@antonpatenko antonpatenko commented Apr 3, 2017

* Added templates for IPinIP and Everflow configuration file.
* Added config.sh to generate configs using templates.
* Extended minigraph.py to read ErspanIPv4 section.

Use {{ erspan_dst[0] }} to read Everflow destination IPv4 address in your config/minigraph file.

    * Added templates for IPinIP and Everflow configuration file.
    * Added config.sh to generate configs using templates.
    * Extended minigraph.py to read ErspanIPv4 section.
@antonpatenko antonpatenko reopened this Apr 3, 2017
"src_ip":"{{ minigraph_lo_interfaces[0]['addr'] }}",
"dst_ip":"{{ minigraph_lo_interfaces[0]['addr'] }}",
"dscp_mode":"uniform",
"ecn_mode":"standard",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by default this should be copy_from_outer, can you check the asic_type and generate corresponding configuration based on the asic_type?

Copy link
Contributor Author

@antonpatenko antonpatenko Apr 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lguohan
which exactly field should be set to copy_from_outer?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the ecn_mode

Copy link
Contributor

@stcheng stcheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you also add a simple unit test in sonic-cfggen about the erspan minigraph parsing and ipinip.conf.j2 and mirror.conf.j2 logics?

@@ -0,0 +1,4 @@
#!/bin/bash -e

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check if the folder exists. later swss.deb package might change.

@@ -50,7 +50,7 @@ elif [ "$HWSKU" == "AS7512" ]; then
elif [ "$HWSKU" == "INGRASYS-S9100-C32" ]; then
ORCHAGENT_ARGS+="-m $MAC_ADDRESS"
elif [ "$HWSKU" == "ACS-MSN2700" ]; then
SWSSCONFIG_ARGS+="msn2700.32ports.buffers.json msn2700.32ports.qos.json "
SWSSCONFIG_ARGS+="msn2700.32ports.buffers.json msn2700.32ports.qos.json ipinip.conf mirror.conf "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be limited to MLNX platform?

Kalimuthu-Velappan pushed a commit to Kalimuthu-Velappan/sonic-buildimage that referenced this pull request Sep 12, 2019
mssonicbld added a commit that referenced this pull request May 18, 2024
… automatically (#18986)

#### Why I did it
src/sonic-platform-common
```
* 862a67c - (HEAD -> master, origin/master, origin/HEAD) Added API to decommison all datapaths of a CMIS compliant module (#471) (10 hours ago) [Prince George]
```
#### How I did it
#### How to verify it
#### Description for the changelog
mssonicbld added a commit that referenced this pull request May 19, 2024
… automatically (#18999)

#### Why I did it
src/sonic-platform-common
```
* 13cf28e - (HEAD -> 202311, origin/202311) Added API to decommison all datapaths of a CMIS compliant module (#471) (22 hours ago) [Prince George]
```
#### How I did it
#### How to verify it
#### Description for the changelog
mssonicbld added a commit that referenced this pull request Jul 6, 2024
…D automatically (#19498)

#### Why I did it
src/sonic-platform-daemons
```
* 74881e1 - (HEAD -> master, origin/master, origin/HEAD) [xcvrd] Modify to support regular expression when parsing the key in media_settings.json (#471) (10 hours ago) [DennisChiuEC]
```
#### How I did it
#### How to verify it
#### Description for the changelog
arun1355492 pushed a commit to arun1355492/sonic-buildimage that referenced this pull request Jul 26, 2024
…D automatically (sonic-net#19498)

#### Why I did it
src/sonic-platform-daemons
```
* 74881e1 - (HEAD -> master, origin/master, origin/HEAD) [xcvrd] Modify to support regular expression when parsing the key in media_settings.json (sonic-net#471) (10 hours ago) [DennisChiuEC]
```
#### How I did it
#### How to verify it
#### Description for the changelog
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Aug 1, 2024
…D automatically (sonic-net#19498)

#### Why I did it
src/sonic-platform-daemons
```
* 74881e1 - (HEAD -> master, origin/master, origin/HEAD) [xcvrd] Modify to support regular expression when parsing the key in media_settings.json (sonic-net#471) (10 hours ago) [DennisChiuEC]
```
#### How I did it
#### How to verify it
#### Description for the changelog
mssonicbld added a commit that referenced this pull request Sep 6, 2024
…D automatically (#20138)

#### Why I did it
src/sonic-platform-daemons
```
* 6cee426 - (HEAD -> 202405, origin/202405) [xcvrd] Modify to support regular expression when parsing the key in media_settings.json (#471) (34 hours ago) [DennisChiuEC]
```
#### How I did it
#### How to verify it
#### Description for the changelog
mssonicbld added a commit that referenced this pull request Oct 3, 2024
…D automatically (#20412)

#### Why I did it
src/sonic-platform-daemons
```
* 01aeddd - (HEAD -> 202311, origin/202311) [xcvrd] Modify to support regular expression when parsing the key in media_settings.json (#471) (4 hours ago) [DennisChiuEC]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants