Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FRR] Added support for L3VNI for EVPN as described in the PR Azure/SONiC#437 #4806

Merged
merged 2 commits into from
Jan 20, 2021

Conversation

kishorekunal01
Copy link
Contributor

@kishorekunal01 kishorekunal01 commented Jun 18, 2020

Sending RMAC with EVPN Type5 prefix to fpmsyncd. This is a temp fix,
This patch will be removed once neighorch is ready to handle the Prefix and ARP(containing RMAC) separately.

- Why I did it
Currently FRR is send Prefix with VNI information to FPMSYNCD, added code to send RMAC along with the prefix.
This is a temp fix. This patch will be removed once neighorch is ready to handle the Prefix and ARP(containing RMAC) separately.

- How I did it
Part of overall EVPN-VXLAN Implementation

- How to verify it
Verified on VS build.

- Description for the changelog

ADD L3 VNI EVPN Support for SONiC, Send RMAC and VNI with prefix to FPMSYNCD

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Kishore Kunal kishore.kunal@broadcom.com

@pavel-shirshov pavel-shirshov self-assigned this Jun 18, 2020
@pavel-shirshov pavel-shirshov self-requested a review June 18, 2020 21:33
@pavel-shirshov
Copy link
Contributor

Hi Kishore,

Can you please upstream your code to FRR?

@kishorekunal01
Copy link
Contributor Author

Hi Kishore,

Can you please upstream your code to FRR?

We are going to upstream to FRR soon, but it will be going to master and will take time to be part of the release.

@pavel-shirshov
Copy link
Contributor

@kishorekunal01 Can you please make a PR with FRR first?

@kishorekunal01
Copy link
Contributor Author

@kishorekunal01 Can you please make a PR with FRR first?

Working on it, to raise PR with FRR

@pavel-shirshov
Copy link
Contributor

@kishorekunal01 thanks!

@kishorekunal01
Copy link
Contributor Author

These changes are inline with FRR7.5 changes. The PR in FRR is FRRouting/frr#7469

@prvattem
Copy link

prvattem commented Jan 11, 2021

- Why I did it
Currently FRR is send Prefix with VNI information to FPMSYNCD, added code to send RMAC and VLAN along with the prefix.

Are you referring to "RMAC and L3VNI" along with the prefix?

@kishorekunal01
Copy link
Contributor Author

- Why I did it
Currently FRR is send Prefix with VNI information to FPMSYNCD, added code to send RMAC and VLAN along with the prefix.

Are you referring to "RMAC and L3VNI" along with the prefix?

I was passing nexthop VLAN information along with prefix, But since nexthop can be extracted from nexthop ifindex(tb[RTA_OIF] ) I am no longer sending VLAN information with prefix. Hence update the review description.

Existing FRR code already send L3VNI information along with the prefix, I have added support to add RMAC information as well with the prefix.

@prvattem
Copy link

prvattem commented Jan 11, 2021

I was passing nexthop VLAN information along with prefix, But since nexthop can be extracted from nexthop ifindex(tb[RTA_OIF] ) I am no longer sending VLAN information with prefix. -
Not sending the VLAN across is the right thing to do. By sending VLAN across, are you not fixing VLANs on either side?

@kishorekunal01
Copy link
Contributor Author

By sending VLAN across, are you not fixing VLANs on either side?

Vlan-Id was used to set the nexthop interface name based on L3VNI to VLAN mapping. So it was not fixed earlier as well. Since the information can be extracted from tb[RTA_OIF] hence removed the information in the new patch.

@kishorekunal01
Copy link
Contributor Author

Created new PR in FRR community as I was not able to resolve static check error.
New PR FRRouting/frr#7852

@prsunny
Copy link
Contributor

prsunny commented Jan 15, 2021

retest mellanox please

@lguohan lguohan merged commit cad2025 into sonic-net:master Jan 20, 2021
lguohan pushed a commit that referenced this pull request Jan 21, 2021
…th prefix to fpmsyncd. (#4806)

Currently FRR is send Prefix with VNI information to FPMSYNCD. This PR allows FRR to send RMAC with EVPN Type5 prefix to fpmsyncd. This is a temp fix. This patch will be removed once neighorch is ready to handle the Prefix and ARP (containing RMAC) separately.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants