modified files relevant to SKU Mellanox-SN3800-D112C8 #4810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prsunny
reviewed
Jun 19, 2020
| @@ -1 +1 @@ | |||
| SAI_INIT_CONFIG_FILE=/usr/share/sonic/hwsku/sai_3800_112x50g_8x100g.xml | |||
There was a problem hiding this comment.
Kindly keep the name as before as that's a convention followed for other SKU's as well. You can check this .
It can be used to identify the file in syncd docker
There was a problem hiding this comment.
addressed in the next commit.
|
retest vsimage please |
prsunny
approved these changes
Jun 19, 2020
prsunny
approved these changes
Jun 19, 2020
|
@sumukhatv for visibility |
|
retest vsimage please |
abdosi
pushed a commit
that referenced
this pull request
Jun 23, 2020
* modified files relevant to SKU Mellanox-SN3800-D112C8 Co-authored-by: Madhan Babu <madhan@arc-build-server.mtr.labs.mlnx>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Modified all the relevant files to modify SKU Mellanox-SN3800-D112C8
How I did it
Modified / Created all the SKU related files using a XML file provided and a sonic_sku_create.py script to generate the files.
How to verify it
Load the new HWKU related config using follow command and reload the config.
sudo sonic-cfggen --preset l2 -p -H -k Mellanox-SN3800-D112C8 > /tmp/newconfig
sudo cp /tmp/newconfig /etc/sonic/config_db.json
sudo config reload
show interfaces status
Description for the changelog
Modified SKU related files buffers_defaults_t0.j2, buffers_defaults_t1.j2, buffers.json.j2, pg_profile_lookup.ini, port_config.ini, qos.json.j2, sai_3800.xml and sai.profile.
- A picture of a cute animal (not mandatory but encouraged)