Tests of FRR templates which rendered by sonic-cfggen #4875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test failure. |
|
This pull request introduces 2 alerts when merging e999a3a into 243268f - view on LGTM.com new alerts:
|
|
Based on my checks, sonic-bgpcfgd uses jinja2-2.11.2, but when sonic-bgpcfgd tests uses subprocess call of sonic-cfggen, it uses jinja2-2.8, which doesn't support our templates. |
|
can you check the lgtm alerts? it seems valid. https://lgtm.com/projects/g/Azure/sonic-buildimage/rev/pr-33b78736cab933c8ee50e631791d81afdd63aea9 |
lguohan
approved these changes
Jul 2, 2020
abdosi
pushed a commit
that referenced
this pull request
Jul 5, 2020
* Tests of FRR templates which rendered by sonic-cfggen
qiluo-msft
pushed a commit
to qiluo-msft/sonic-buildimage
that referenced
this pull request
Jul 12, 2020
* Tests of FRR templates which rendered by sonic-cfggen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
To test FRR templates which are rendered by sonic-cfggen
- How I did it
I use sonic-cfggen from the repo with manually prepared source information and manually prepared destination files.
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)