Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[devices] Update SFP keys to align with new standard #4975

Merged
merged 2 commits into from
Jul 16, 2020
Merged

[devices] Update SFP keys to align with new standard #4975

merged 2 commits into from
Jul 16, 2020

Conversation

jleveque
Copy link
Contributor

Align SFP key names with new standard defined in sonic-net/sonic-platform-common#97

  • hardwarerev -> hardware_rev
  • serialnum -> serial
  • manufacturename -> manufacturer
  • modelname -> model
  • Connector -> connector

@jleveque jleveque requested review from keboliu and abdosi July 16, 2020 01:34
@jleveque jleveque self-assigned this Jul 16, 2020
@jleveque
Copy link
Contributor Author

Retest vsimage please

@jleveque
Copy link
Contributor Author

Retest mellanox please

@jleveque
Copy link
Contributor Author

Retest vsimage please

@jleveque jleveque merged commit 9905d93 into sonic-net:master Jul 16, 2020
@jleveque jleveque deleted the update_sfp_info_keys branch July 16, 2020 20:03
@jleveque jleveque mentioned this pull request Jul 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdosi abdosi abdosi approved these changes

@keboliu keboliu Awaiting requested review from keboliu

Assignees

@jleveque jleveque

Labels
Enhancement ➕ Platform: Accton Platform: Celestica Platform: DellEMC Platform: Inventec Platform: Mellanox Request for 202006 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jleveque @abdosi