[sonic-py-common] Add interface utilities #5113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
judyjoseph
force-pushed
the
py-commmon-intf
branch
from
2841555
to
082c26a
Compare
jleveque
suggested changes
Aug 6, 2020
This comment has been minimized.
This comment has been minimized.
jleveque
suggested changes
Aug 6, 2020
jleveque
previously approved these changes
Aug 7, 2020
jleveque
changed the title
|
retest mellanox please |
|
retest this please |
|
retest broadcom please |
|
@lguohan , please share your comments -- if other generic interface APIs which we could add here. |
|
retest this please |
judyjoseph
force-pushed
the
py-commmon-intf
branch
from
7b7fdc5
to
11ca58d
Compare
|
retest mellanox please |
3 similar comments
|
retest mellanox please |
|
retest mellanox please |
|
retest mellanox please |
jleveque
suggested changes
Aug 15, 2020
|
@jleveque please could you approve if the updates are ok |
jleveque
approved these changes
Aug 18, 2020
abdosi
pushed a commit
that referenced
this pull request
Sep 6, 2020
* Add sonic_interface.py in sonic-py-common for sonic interface utilities to keep this SONIC PREFIX naming convention in one place in py-common and all modules/applications use the functions defined here.
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
* Add sonic_interface.py in sonic-py-common for sonic interface utilities to keep this SONIC PREFIX naming convention in one place in py-common and all modules/applications use the functions defined here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
There are many places in the code where there is hardcoding to the way we refer to the Sonic front-panel/backplane interface prefixes. The idea with this PR is to keep this SONIC PREFIX naming convention in one place in py-common and all modules/applications use the functions defined here.
- How I did it
To start with I have add a file sonic_interface.py in sonic-py-common with API's to get the sonic interface prefix string. Can add more sonic interface specific utilities here. This is useful especially in the sonic-utilities show/config modules.
- How to verify it
Newly added functions were verified with CLI commands.