[multi-asic]: Update port_config files for multi-asic vs image #5121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for multi-asic platform. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
judyjoseph
reviewed
Aug 7, 2020
| Ethernet56 57,58,59,60 Ethernet1/15 14 Eth14-ASIC0 E 40000 | ||
| Ethernet60 61,62,63,64 Ethernet1/16 15 Eth15-ASIC0 E 40000 | ||
| Ethernet64 69,70,71,72 Eth16-ASIC0 0 Eth16-ASIC0 I 40000 | ||
| Ethernet68 65,66,67,68 Eth17-ASIC0 1 Eth17-ASIC0 I 40000 |
There was a problem hiding this comment.
The interface name should be for Backplane interface here for ASIC0 ?
There was a problem hiding this comment.
Fixed the interface names.
There was a problem hiding this comment.
do we want to have "Ext", "Int", wonder if in the future we will have more role/type? for example, fabric link.
There was a problem hiding this comment.
Updated as per suggestion.
Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
judyjoseph
previously approved these changes
Aug 7, 2020
ports. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
lguohan
approved these changes
Aug 14, 2020
abdosi
pushed a commit
that referenced
this pull request
Aug 19, 2020
Modify port_config.ini files multi-asic vs platform. Changes done: - Add new columns: index, asic_port_name, role(Int/Ext) - Modify alias of interface names. Alias should match the interface names present in minigraph file. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
3 tasks
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…-net#5121) Modify port_config.ini files multi-asic vs platform. Changes done: - Add new columns: index, asic_port_name, role(Int/Ext) - Modify alias of interface names. Alias should match the interface names present in minigraph file. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
Modify port_config.ini files to match with the changes done for multi-asic platform.
- How I did it
Added new columns: index, asic_port_name, role(Internal/external)
Modify alias of interface names. Alias should match the interface names present in minigraph file.
- How to verify it
Should be able to bring up multi-asic VS image.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)