Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[radv] Reduce Calls to SONiC Cfggen #5178

Merged

Conversation

tahmed-dev
Copy link
Contributor

Calls to sonic-cfggen is CPU expensive. This PR reduces calls to
sonic-cfggen to one call during startup when starting radv service.

singed-off-by: Tamer Ahmed tamer.ahmed@microsoft.com

- Why I did it
Reduce time required when invoking swss

- How I did it
Used template batch mode to batch together three calls into one call to sonic-cfggen

- How to verify it

root@str-s6000-acs-14:/# time ./docker-init-old.sh 

real	0m5.099s
user	0m4.180s
sys	0m0.585s
root@str-s6000-acs-14:/# time ./docker-init-new.sh 

real	0m1.583s
user	0m1.335s
sys	0m0.200s
root@str-s6000-acs-14:/# diff /etc/supervisor/conf.d/supervisord.conf.old /etc/supervisor/conf.d/supervisord.conf.new 
root@str-s6000-acs-14:/# diff /etc/radvd.conf.old /etc/radvd.conf.new 
root@str-s6000-acs-14:/# diff /usr/bin/wait_for_intf.sh.old /usr/bin/wait_for_intf.sh.new 
root@str-s6000-acs-14:/# 

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

Calls to sonic-cfggen is CPU expensive. This PR reduces calls to
sonic-cfggen to one call during startup when starting radv service.

singed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
@tahmed-dev tahmed-dev marked this pull request as ready for review August 14, 2020 01:33
@tahmed-dev tahmed-dev merged commit adcca53 into sonic-net:master Aug 17, 2020
abdosi pushed a commit that referenced this pull request Oct 7, 2020
Calls to sonic-cfggen is CPU expensive. This PR reduces calls to
sonic-cfggen to one call during startup when starting radv service.

singed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
lguohan pushed a commit that referenced this pull request Oct 30, 2020
Calls to sonic-cfggen is CPU expensive. This PR reduces calls to
sonic-cfggen to one call during startup when starting radv service.

singed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
abdosi pushed a commit that referenced this pull request Dec 4, 2020
Calls to sonic-cfggen is CPU expensive. This PR reduces calls to
sonic-cfggen to one call during startup when starting radv service.

singed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
abdosi pushed a commit that referenced this pull request Dec 22, 2020
Calls to sonic-cfggen is CPU expensive. This PR reduces calls to
sonic-cfggen to one call during startup when starting radv service.

singed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
Calls to sonic-cfggen is CPU expensive. This PR reduces calls to
sonic-cfggen to one call during startup when starting radv service.

singed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
tahmed-dev added a commit to tahmed-dev/sonic-buildimage that referenced this pull request Apr 7, 2021
PR sonic-net#4599 changed startup
script name from wait_for_intf.sh.j2 to wait_for_link.sh.j2, however
when PR sonic-net#5178 was cherry-
picked, the script name was not changed to wait_for_link.sh.

signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
lguohan pushed a commit that referenced this pull request Apr 8, 2021
PR #4599 changed startup
script name from wait_for_intf.sh.j2 to wait_for_link.sh.j2, however
when PR #5178 was cherry-
picked, the script name was not changed to wait_for_link.sh.

signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants