Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit dependency for swss #519

Merged
merged 2 commits into from
Apr 20, 2017
Merged

Add explicit dependency for swss #519

merged 2 commits into from
Apr 20, 2017

Conversation

qiluo-msft
Copy link
Collaborator

No description provided.

stcheng
stcheng reviewed Apr 19, 2017
View reviewed changes
rules/swss.mk Outdated
@@ -3,8 +3,8 @@
SWSS = swss_1.0.0_amd64.deb
$(SWSS)_SRC_PATH = $(SRC_PATH)/sonic-swss
$(SWSS)_DEPENDS += $(LIBSAIREDIS_DEV) $(LIBSAIMETADATA_DEV) $(LIBTEAM_DEV) \
$(LIBTEAMDCT) $(LIBTEAM_UTILS)
$(SWSS)_RDEPENDS += $(LIBSAIREDIS) $(LIBSAIMETADATA) $(LIBTEAM)
$(LIBTEAMDCT) $(LIBTEAM_UTILS) $(LIBHIREDIS_DEV) $(LIBSWSSCOMMON_DEV)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think swss doesn't depend on libhiredis but swss-common depends on that.
So including swsscommon is enough.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@pavel-shirshov
Copy link
Contributor

Why do we need this?
How did that work before?

@stcheng
Copy link
Contributor

stcheng commented Apr 19, 2017

@pavel-shirshov because swss also requires sairedis and sairedis depends on swss-common.

@qiluo-msft
Copy link
Collaborator Author

https://github.com/Azure/sonic-swss/blob/master/configure.ac#L41
swss should explicitly depend on libswsscommon.

@lguohan
Copy link
Collaborator

lguohan commented Apr 19, 2017

so there is about adding explicitly dependency for swss, not missing? Then, maybe you can change the commit message to clarify this.

@qiluo-msft qiluo-msft changed the title Add missing dependencies of swss Add explicitly dependency for swss Apr 19, 2017
@qiluo-msft qiluo-msft changed the title Add explicitly dependency for swss Add explicit dependency for swss Apr 19, 2017
@qiluo-msft qiluo-msft merged commit ea51e1c into sonic-net:master Apr 20, 2017
@qiluo-msft qiluo-msft deleted the qiluo/fix-dep1 branch April 20, 2017 04:01
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Apr 30, 2019
@yxieca
[sonic-utilities] advance submodule head to latest
a4e7a83 
Submodule src/sonic-utilities 6ee0aea..b531934:
  > [db migrator] Introduce the DB migration infrastructure (sonic-net#519)
  > Skip INTERFACE entries w/o prefix (sonic-net#477)
  > Bring queue storm status to 'pfcwd show stats' (sonic-net#500)
  > Align PSU DB count field with the schema Spec. (sonic-net#509)
  > [scripts] remove duplicate script copying for nbrshow (sonic-net#517)
  > If fast-reboot-dump gives an error, don't continue with fast-reboot (sonic-net#515)
  > load_minigraph: restart hostcfgd (sonic-net#511)
  > [fast/warm reboot] add some sanity check before warm reboot (sonic-net#510)
  > show BPS, PPS, UTIL rates w/o previous clear (sonic-net#508)
  > In sync with our latest change, where we default failthrough to be False. (sonic-net#507)
  > Add warm-boot feature processing for wedge100bf_32x/65x platforms (sonic-net#485)
  > [generate_dump] system dump improvements (sonic-net#503)
  > [neighbor advertiser] convert int to string before concatenating (sonic-net#505)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@yxieca yxieca mentioned this pull request Apr 30, 2019
Merged
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Apr 30, 2019
@yxieca
[201811][utilities] advance sub-module head
a94a5ca 
Submodule src/sonic-utilities 9005508..584e706:
  > [db migrator] Introduce the DB migration infrastructure (sonic-net#519)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@yxieca yxieca mentioned this pull request Apr 30, 2019
Merged
yxieca added a commit that referenced this pull request Apr 30, 2019
@yxieca
[sonic-utilities] advance submodule head to latest (#2842)
df45a77 
Submodule src/sonic-utilities 6ee0aea..b531934:
  > [db migrator] Introduce the DB migration infrastructure (#519)
  > Skip INTERFACE entries w/o prefix (#477)
  > Bring queue storm status to 'pfcwd show stats' (#500)
  > Align PSU DB count field with the schema Spec. (#509)
  > [scripts] remove duplicate script copying for nbrshow (#517)
  > If fast-reboot-dump gives an error, don't continue with fast-reboot (#515)
  > load_minigraph: restart hostcfgd (#511)
  > [fast/warm reboot] add some sanity check before warm reboot (#510)
  > show BPS, PPS, UTIL rates w/o previous clear (#508)
  > In sync with our latest change, where we default failthrough to be False. (#507)
  > Add warm-boot feature processing for wedge100bf_32x/65x platforms (#485)
  > [generate_dump] system dump improvements (#503)
  > [neighbor advertiser] convert int to string before concatenating (#505)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca added a commit that referenced this pull request Apr 30, 2019
@yxieca
[201811][utilities] advance sub-module head (#2844)
f22666c 
Submodule src/sonic-utilities 9005508..584e706:
  > [db migrator] Introduce the DB migration infrastructure (#519)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
MichelMoriniaux pushed a commit to criteo-forks/sonic-buildimage that referenced this pull request May 28, 2019
@yxieca @MichelMoriniaux
[sonic-utilities] advance submodule head to latest (sonic-net#2842)
d8bcec3 
Submodule src/sonic-utilities 6ee0aea..b531934:
  > [db migrator] Introduce the DB migration infrastructure (sonic-net#519)
  > Skip INTERFACE entries w/o prefix (sonic-net#477)
  > Bring queue storm status to 'pfcwd show stats' (sonic-net#500)
  > Align PSU DB count field with the schema Spec. (sonic-net#509)
  > [scripts] remove duplicate script copying for nbrshow (sonic-net#517)
  > If fast-reboot-dump gives an error, don't continue with fast-reboot (sonic-net#515)
  > load_minigraph: restart hostcfgd (sonic-net#511)
  > [fast/warm reboot] add some sanity check before warm reboot (sonic-net#510)
  > show BPS, PPS, UTIL rates w/o previous clear (sonic-net#508)
  > In sync with our latest change, where we default failthrough to be False. (sonic-net#507)
  > Add warm-boot feature processing for wedge100bf_32x/65x platforms (sonic-net#485)
  > [generate_dump] system dump improvements (sonic-net#503)
  > [neighbor advertiser] convert int to string before concatenating (sonic-net#505)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Kalimuthu-Velappan pushed a commit to Kalimuthu-Velappan/sonic-buildimage that referenced this pull request Sep 12, 2019
@yxieca
[db migrator] Introduce the DB migration infrastructure (sonic-net#519)
b531934 
* [db migrator] Introduce the DB migration infrastructure

- Add infrastructure to migrate DB contents from a lower version schema
  to a higher version schema, eventually reach latest version.
- if config load_minigraph is executed, the db schema version is always
  the latest.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

* [db migrator] address issues found in test
lguohan added a commit to lguohan/sonic-buildimage that referenced this pull request Dec 2, 2019
@lguohan
[submodule]: update sonic-sairedis
5cce9ff 
* 27a93ff 2019-11-25 | Don't learn fdb entries on LAG when rif based (sonic-net#538) [Kamil Cudnik]
* 5ef1764 2019-11-22 | Changes in sonic-sairedis repo to support the NAT feature. (sonic-net#519) [Kiran Kumar Kella]

Signed-off-by: Guohan Lu <gulv@microsoft.com>
@lguohan lguohan mentioned this pull request Dec 2, 2019
Merged
lguohan added a commit that referenced this pull request Dec 2, 2019
@lguohan
[submodule]: update sonic-sairedis (#3833)
f0a3d85 
* 27a93ff 2019-11-25 | Don't learn fdb entries on LAG when rif based (#538) [Kamil Cudnik]
* 5ef1764 2019-11-22 | Changes in sonic-sairedis repo to support the NAT feature. (#519) [Kiran Kumar Kella]

Signed-off-by: Guohan Lu <gulv@microsoft.com>
dmytroxshevchuk pushed a commit to dmytroxshevchuk/sonic-buildimage that referenced this pull request Aug 31, 2020
@kirankella @lguohan
Changes in sonic-sairedis repo to support the NAT feature. (sonic-net…
5ef1764 
…#519)

* Changes in sonic-sairedis repo to support the NAT feature.

Signed-off-by: kiran.kella@broadcom.com
dgsudharsan added a commit to dgsudharsan/sonic-buildimage that referenced this pull request Sep 7, 2022
@dgsudharsan
[202012][submodule] Update sonic-swss-common submodule
494b058 
Update sonic-swss-common submodule pointer to include the following:
* VxLAN Tunnel Counters and Rates implementation (sonic-net#519) ([sonic-net#679](sonic-net/sonic-swss-common#679))

Signed-off-by: dgsudharsan <sudharsand@nvidia.com>
@dgsudharsan dgsudharsan mentioned this pull request Sep 7, 2022
Merged
7 tasks
prsunny pushed a commit that referenced this pull request Sep 9, 2022
@dgsudharsan
[202012][submodule] Update sonic-swss-common submodule (#11994)
5b9fc0a 
Update sonic-swss-common submodule pointer to include the following:
* VxLAN Tunnel Counters and Rates implementation (#519) ([#679](sonic-net/sonic-swss-common#679))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stcheng stcheng stcheng approved these changes

@lguohan lguohan lguohan approved these changes

Assignees
No one assigned
Labels
Enhancement ➕
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qiluo-msft @pavel-shirshov @stcheng @lguohan