Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docker-ptf]replace ping utility from inetutils-ping to iputils-ping #523

Merged
merged 4 commits into from
May 2, 2017
Merged

[docker-ptf]replace ping utility from inetutils-ping to iputils-ping #523

merged 4 commits into from
May 2, 2017

Conversation

maggiemsft
Copy link
Contributor

the inetutils-ping does not have source interface '-I' option

stcheng
stcheng suggested changes Apr 20, 2017
View reviewed changes
dockers/docker-ptf/Dockerfile.j2 Outdated
@@ -70,6 +70,9 @@ RUN rm -rf /debs \
&& mkdir -p /opt \
&& cd /opt \
&& wget https://raw.githubusercontent.com/p4lang/ptf/master/ptf_nn/ptf_nn_agent.py
&& wget https://launchpadlibrarian.net/265451319/iputils-ping_20150815-2ubuntu3_amd64.deb
&& dpkg -r inetutils-ping
&& dpkg -i dpkg -i iputils-ping_20150815-2ubuntu3_amd64.deb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two dpkg -i ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sharp eye, thank you!

lguohan
lguohan reviewed Apr 20, 2017
View reviewed changes
dockers/docker-ptf/Dockerfile.j2 Outdated
@@ -70,6 +70,9 @@ RUN rm -rf /debs \
&& mkdir -p /opt \
&& cd /opt \
&& wget https://raw.githubusercontent.com/p4lang/ptf/master/ptf_nn/ptf_nn_agent.py
&& wget https://launchpadlibrarian.net/265451319/iputils-ping_20150815-2ubuntu3_amd64.deb
&& dpkg -r inetutils-ping
&& dpkg -i iputils-ping_20150815-2ubuntu3_amd64.deb
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use apt-get iptuils-ping

jleveque
jleveque reviewed Apr 28, 2017
View reviewed changes
dockers/docker-ptf/Dockerfile.j2 Outdated
libqt5network5
libqt5network5 \
&& dpkg -r inetutils-ping \
&& apt-get install -y iputils-ping
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we're squashing dockers, this would be cleaner if broken out into a separate RUN dpkg -r inetutils-ping statement. Thoughts?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can do dpkg -r inetutils-ping before line 15, and then attach iptuils-ping here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the recommandation

@maggiemsft maggiemsft changed the title replace ping utility from inetutils-ping to iputils-ping [docker-ptf]replace ping utility from inetutils-ping to iputils-ping May 1, 2017
stcheng
stcheng reviewed May 1, 2017
View reviewed changes
dockers/docker-ptf/Dockerfile.j2
@@ -40,7 +40,9 @@ RUN sed --in-place 's/httpredir.debian.org/debian-archive.trafficmanager.net/' /
wget \
cmake \
libqt5core5a \
libqt5network5
libqt5network5 \
iputils-ping
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so it will replace the old one?

@maggiemsft
Copy link
Contributor Author

I locally built the docker image and loaded and start in my local docker machine. Look like it was building correctly with the new package.

root@85d6dcf4b6f4:/# dpkg -l | grep ping
ii iputils-ping 3:20121221-5+b2 amd64 Tools to test the reachability of network hosts
root@85d6dcf4b6f4:/# ping
Usage: ping [-aAbBdDfhLnOqrRUvV] [-c count] [-i interval] [-I interface]
[-m mark] [-M pmtudisc_option] [-l preload] [-p pattern] [-Q tos]
[-s packetsize] [-S sndbuf] [-t ttl] [-T timestamp_option]
[-w deadline] [-W timeout] [hop1 ...] destination

My local machine ping package is:
masun@masun-vm0:~/sonic/sonic-buildimage/target$ dpkg -l |grep ping
ii iputils-ping 3:20150815-2ubuntu3 amd64 Tools to test the reachability of network hosts
so I assume it was build correctly.

@maggiemsft maggiemsft merged commit 4dfe2a2 into sonic-net:master May 2, 2017
@stcheng
Copy link
Contributor

stcheng commented May 2, 2017

thanks

@maggiemsft maggiemsft deleted the masun/replace_ping_util branch July 18, 2017 17:33
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020
@prsunny
Allocate buffer for 256 entries for ACL resource query (sonic-net#523)
6189eaa 
* Allocate buffer for 256 entries for ACL resource query

* Changed to MACRO
@shlomibitton shlomibitton mentioned this pull request Aug 24, 2021
Merged
TACappleman added a commit to Metaswitch/sonic-buildimage that referenced this pull request Aug 24, 2021
@TACappleman
Updating sonic-swss-common submodule
6b60192 
> Add a new field for FLEX_COUNTER_TABLE to indicate delay for flex counters (sonic-net#523)
> [logger] Make map access thread safe and proper terminate thread (sonic-net#510)
> Test with coverage output, publish gcov on Azure pipelines (sonic-net#517)
> Update schema.h to include config_db DHCP and state_db counter table (sonic-net#521)
> [schema] Add next hop group table to schema (sonic-net#475)
> Fix: DBInterface::get() return nullable strings (sonic-net#516)
> [netlink]refill netlink cache when failing to get the link object by name. (sonic-net#506)
> Fix test_ConfigDBSubscribe timing risk (sonic-net#512)
> added missing headers for building with gcc-10.3 (sonic-net#494)
> Modify the hardcode separator ":" to variable. (sonic-net#473)
@TACappleman TACappleman mentioned this pull request Aug 24, 2021
Closed
5 tasks
prsunny pushed a commit that referenced this pull request Aug 25, 2021
@shlomibitton
Update sonic-swss-common submodule (#8565)
948ad54 
508202b 2021-08-24 Add a new field for FLEX_COUNTER_TABLE to indicate delay for flex counters (#523)
9fd7dbf 2021-08-20 [logger] Make map access thread safe and proper terminate thread (#510)
e4c3d0b 2021-08-20 Test with coverage output, publish gcov on Azure pipelines (#517)
ef21bec 2021-08-18 Update schema.h to include config_db DHCP and state_db counter table (#521)
4e4eb9d 2021-08-19 [schema] Add next hop group table to schema (#475)

Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
judyjoseph added a commit that referenced this pull request Sep 2, 2021
@judyjoseph
Submodule updates
1ca6dc9 
sonic-swss

73f6f68 [Flex Counters] Delay flex counters even if tables are present in the DB (#1877)
5edb9e5 [buffer orch] Bugfix: Don't query counter SAI_BUFFER_POOL_STAT_XOFF_ROOM_WATERMARK_BYTES on a pool where it is not supported (#1857)
fce0c60 [crm] Fix for Issue #8036 (#1829)

sonic-utilities

2630ac1 [Fast-reboot] Set flex counters delay indicator to prevent flex counters enablement after fast-reboot (#1768)
606f1b1 [portstat pfcstat] Unify the packet number format in the output of portstat and pfcstat in all cases (#1755)
2c6a15e [ecnconfig] Fix exception seen during display and add unit tests (#1784)
9b1995e Fix logic in RIF counters print (#1732)

sonic-swss-comon

3e7b81f Add a new field for FLEX_COUNTER_TABLE to indicate delay for flex counters (#523)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleveque jleveque jleveque left review comments

@stcheng stcheng stcheng approved these changes

@lguohan lguohan lguohan approved these changes

Assignees

@maggiemsft maggiemsft

Labels
Enhancement ➕
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maggiemsft @stcheng @lguohan @jleveque