Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced Feature Table state enable/disable for multi-asic platforms. #5358

Merged
merged 7 commits into from
Sep 22, 2020
Merged

Enhanced Feature Table state enable/disable for multi-asic platforms. #5358

merged 7 commits into from
Sep 22, 2020

Commits on Sep 10, 2020

  1. Enhanced Feature Table state enable/disbale for multi-asic platforms. 

    In Multi-asic for some features we can service per asic so we need to
get list of all services.

Also updated logic to return if any one of systemctl command return failure
and make sure syslog of feature getting enable/disable only come when
all commads are sucessful.

Moved the service list get api from sonic-util to sonic-py-common

Signed-off-by: Abhishek Dosi <abdosi@abdosi-ubuntu-vm0.nwp1qucpfg5ejooejenqshkj3e.cx.internal.cloudapp.net>
    Abhishek Dosi committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    f74afe2 View commit details
    Browse the repository at this point in the history

  2. Make sure to retun None for both service list in case of error. 

    Signed-off-by: Abhishek Dosi <abdosi@abdosi-ubuntu-vm0.nwp1qucpfg5ejooejenqshkj3e.cx.internal.cloudapp.net>
    Abhishek Dosi committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    2364973 View commit details
    Browse the repository at this point in the history

  3. Return empty list as fail condition 

    Signed-off-by: Abhishek Dosi <abdosi@abdosi-ubuntu-vm0.nwp1qucpfg5ejooejenqshkj3e.cx.internal.cloudapp.net>
    Abhishek Dosi committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    524eb46 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2020

  1. Address Review Comments. 

    Made init_cfg.json.j2 knowledegable of Feature
service is global scope or per asic scope

Signed-off-by: Abhishek Dosi <abdosi@abdosi-ubuntu-vm0.nwp1qucpfg5ejooejenqshkj3e.cx.internal.cloudapp.net>
    Abhishek Dosi committed Sep 19, 2020
    Configuration menu
    Copy the full SHA
    383aecd View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into multiasic_feature… 

    …table
    Abhishek Dosi committed Sep 19, 2020
    Configuration menu
    Copy the full SHA
    75fa914 View commit details
    Browse the repository at this point in the history

  3. Fix merge conflict

    Abhishek Dosi committed Sep 19, 2020
    Configuration menu
    Copy the full SHA
    084e4ab View commit details
    Browse the repository at this point in the history

  4. Address Review Comment. 

    Signed-off-by: Abhishek Dosi <abdosi@abdosi-ubuntu-vm0.nwp1qucpfg5ejooejenqshkj3e.cx.internal.cloudapp.net>
    Abhishek Dosi committed Sep 19, 2020
    Configuration menu
    Copy the full SHA
    855658f View commit details
    Browse the repository at this point in the history