-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sonic-utilities] Build and install as a Python wheel package #5409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retest vsimage please |
lguohan
approved these changes
Sep 21, 2020
@jleveque , can you also check if any change is needed in sonic-mgmt repo? |
3 tasks
@lguohan: sonic-mgmt PR is here: sonic-net/sonic-mgmt#2247 |
jleveque
added a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Sep 22, 2020
…cal/bin/ (#2247) As of sonic-net/sonic-buildimage#5409, sonic-utilities is now being installed as a Python wheel package. As such, the installation path for scripts/entrypoints has changed from /usr/bin/ to /usr/local/bin. This PR aligns sonic-mgmt code with those changes by updating all references to sonic-utilities scripts/entrypoints to either reference the new /usr/local/bin/ location or remove absolute path entirely where applicable.
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…net#5409) We are moving toward building all Python packages for SONiC as wheel packages rather than Debian packages. This will also allow us to more easily transition to Python 3. Python files are now packaged in "sonic-utilities" Pyhton wheel. Data files are now packaged in "sonic-utilities-data" Debian package. **- How I did it** - Build and install sonic-utilities as a Python package - Remove explicit installation of wheel dependencies, as these will now get installed implicitly by pip when installing sonic-utilities as a wheel - Build and install new sonic-utilities-data package to install data files required by sonic-utilities applications - Update all references to sonic-utilities scripts/entrypoints to either reference the new /usr/local/bin/ location or remove absolute path entirely where applicable Submodule updates: * src/sonic-utilities aa27dd9...2244d7b (5): > Support building sonic-utilities as a Python wheel package instead of a Debian package (sonic-net#1122) > [consutil] Display remote device name in show command (sonic-net#1120) > [vrf] fix check state_db error when vrf moving (sonic-net#1119) > [consutil] Fix issue where the ConfigDBConnector's reference is missing (sonic-net#1117) > Update to make config load/reload backward compatible. (sonic-net#1115) * src/sonic-ztp dd025bc...911d622 (1): > Update paths to reflect new sonic-utilities install location, /usr/local/bin/ (sonic-net#19)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
We are moving toward building all Python packages for SONiC as wheel packages rather than Debian packages. This will also allow us to more easily transition to Python 3.
Python files are now packaged in "sonic-utilities" Pyhton wheel. Data files are now packaged in "sonic-utilities-data" Debian package.
This PR will need to update the following submodules once these PRs are merged:
Submodule updates:
src/sonic-utilities aa27dd9...2244d7b (5):
src/sonic-ztp dd025bc...911d622 (1):
- How I did it
- How to verify it
Ensure all CLI-related functionality continues to work as expected