-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bash.bashrc] Add reverse SSH script to bash.bashrc #5438
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
previously requested changes
Sep 26, 2020
retest please |
Blueve
force-pushed
the
dev/jika/ressh
branch
from
September 29, 2020 04:44
2dde1b8
to
2ef8b1d
Compare
Blueve
commented
Sep 30, 2020
Blueve
force-pushed
the
dev/jika/ressh
branch
from
October 24, 2020 02:38
2ef8b1d
to
060d2aa
Compare
yxieca
previously approved these changes
Oct 27, 2020
Hi @jleveque, I have updated the PR. Could you please take a look? |
lguohan
reviewed
Oct 28, 2020
lguohan
reviewed
Oct 28, 2020
This was referenced Nov 5, 2020
yxieca
approved these changes
Nov 23, 2020
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
* [bash.bashrc] Add reverse SSH script to bash.bashrc * Fix command issue and add emptt line before EOF * Add checks for SSH_TARGET_CONSOLE_LINE Signed-off-by: Jing Kan jika@microsoft.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
To support reverse SSH for console connection, we need to add the script to attach to console line automatically after user login with reverse SSH.
(see HLD for more detail: https://github.com/Azure/SONiC/blob/master/doc/console/SONiC-Console-Switch-High-Level-Design.md#313-reverse-ssh)
The script will be executed only when this feature is available in SONiC: Blueve/openssh-portable#1
- How I did it
Add script to
/etc/bash.bashrc
to support reverse ssh function.- How to verify it
Functional Test
sudo picocom
instead ofsudo connect
)- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
My first pet. My cutest boy. My favorite friend, My family. My cat, the cat I'll never to be seen again... R.I.P Cloud·Cake (2020-09-24)