Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Skip pcied on mellanox platform #5471

Closed

Conversation

Junchao-Mellanox
Copy link
Collaborator

@Junchao-Mellanox Junchao-Mellanox commented Sep 27, 2020

- Why I did it

pcied is not supported on mellanox platform and may cause regression failure.

- How I did it

Skip pcied in pmon_daemon_control.json

- How to verify it

Manual test

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@lguohan
Copy link
Collaborator

lguohan commented Oct 1, 2020

please supply data to support pcied.

Copy link
Collaborator

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i do not think we should skip, instead we should add needed data to enable the check.

@liat-grozovik
Copy link
Collaborator

@lguohan as this is new req which is not yet supported and should be added to all Mellanox switches we should skip it for now and once we deliver the info for all supported platforms we should enable it again.

@sujinmkang
Copy link
Collaborator

@Junchao-Mellanox Since the pcie configuration file is not located in the expected platform directory, then pcied will just exit. Did you see any problem with the pcied?

@Junchao-Mellanox
Copy link
Collaborator Author

@Junchao-Mellanox Since the pcie configuration file is not located in the expected platform directory, then pcied will just exit. Did you see any problem with the pcied?

It fails the reboot test due to check_pmon_daemon_status report that pcied is not there.

@Junchao-Mellanox
Copy link
Collaborator Author

Close as Kebo will add a configuration file for pcied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants