[platform] Remove references to deprecated get_serial_number() method in Chassis class #5649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
approved these changes
Oct 18, 2020
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
… in Chassis class (sonic-net#5649) The `get_serial_number()` method in the ChassisBase and ModuleBase classes was redundant, as the `get_serial()` method is inherited from the DeviceBase class. This method was removed from the base classes in sonic-platform-common and the submodule was updated in sonic-net#5625. This PR aligns the existing vendor platform API implementations to remove the `get_serial_number()` methods and ensure the `get_serial()` methods are implemented, if they weren't previously. Note that this PR does not modify the Dell platform API implementations, as this will be handled as part of sonic-net#5609
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
The
get_serial_number()method in the ChassisBase and ModuleBase classes was redundant, as theget_serial()method is inherited from the DeviceBase class. This method was removed from the base classes in sonic-platform-common and the submodule was updated in #5625.This PR aligns the existing vendor platform API implementations to remove the
get_serial_number()methods and ensure theget_serial()methods are implemented, if they weren't previously.Note that this PR does not modify the Dell platform API implementations, as this will be handled as part of #5609
- How I did it
Remove
get_serial_number()methods from existing platform API implementations (except Dell -- see above) and ensure theget_serial()method is implemented, if it wasn't previously.