Revert "[docker-base]: Rate limit priority INFO and lower in syslog" #5763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theasianpianist
requested review from
lguohan,
jleveque,
qiluo-msft,
yxieca and
daall
|
Are we sure we don't want to keep this change? If some other info-level log message starts spamming, we could rate-limit and lose more important messages, correct? Or should we revert it for now and keep it in our back pocket in case we decide it's needed in the future? |
yxieca
approved these changes
Oct 31, 2020
|
retest this baseimage please |
|
retest baseimage please |
|
@jleveque We've only been seeing this rate limiting from orchagent, and the default log level for that is |
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…onic-net#5763) * This was a temporary fix for orchagent spamming log messages and causing rate limiting, leading to critical messages being dropped for the syslog. No longer needed since sonic-net/sonic-sairedis#680 was merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #5666
Since sonic-net/sonic-sairedis#680 has been merged, this is no longer necessary.