Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[init_cfg.json.j2]: only enable gbsyncd feature for vs platform #5815

Merged
merged 3 commits into from
Nov 7, 2020

Conversation

lguohan
Copy link
Collaborator

@lguohan lguohan commented Nov 4, 2020

currently only vs platform has gdbsyncd feature built

Signed-off-by: Guohan Lu lguohan@gmail.com

- Why I did it
currently only vs platform has gdbsyncd feature built

- How I did it
use jinja2 template to enable the feature only on vs platform.

- How to verify it
will download the image built and try.

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

currently only vs platform has gdbsyncd feature built

Signed-off-by: Guohan Lu <lguohan@gmail.com>
@lguohan lguohan requested a review from jleveque November 4, 2020 20:08
jleveque
jleveque previously approved these changes Nov 4, 2020
prsunny
prsunny previously approved these changes Nov 5, 2020
Signed-off-by: Guohan Lu <lguohan@gmail.com>
@lguohan lguohan dismissed stale reviews from prsunny and jleveque via d874fb0 November 5, 2020 08:19
@lguohan lguohan marked this pull request as ready for review November 5, 2020 08:59
jleveque
jleveque previously approved these changes Nov 5, 2020
@lguohan
Copy link
Collaborator Author

lguohan commented Nov 6, 2020

retest vsimage please

@lguohan
Copy link
Collaborator Author

lguohan commented Nov 6, 2020

retest vsimage please

Signed-off-by: Guohan Lu <lguohan@gmail.com>
@lguohan lguohan merged commit e6796da into sonic-net:master Nov 7, 2020
@lguohan lguohan deleted the gbsyncd branch November 7, 2020 08:46
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
…c-net#5815)

currently only vs platform has gdbsyncd feature built

Signed-off-by: Guohan Lu <lguohan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants