Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[device/celestica]: Add xcvrd event support for Seastone-DX010 #5896

Merged
merged 6 commits into from
Dec 14, 2020

Conversation

mudsut4ke
Copy link
Contributor

@mudsut4ke mudsut4ke commented Nov 11, 2020

- Why I did it

  • The xcvr service requires an event detection function, unplug or plug in the transceiver.

Fix #5853

- How I did it

  • Add sysfs interrupt to notify userspace app of external interrupt
  • Implement get_change_event() in chassis api.

- How to verify it

  • Verify xcvrd running with error in syslog
  • Verify port status and port information with this following command
    • show interfaces status
    • show interfaces transceiver eeprom
  • Log : xcvrd.log

Signed-off-by: Wirut Getbamrung [wgetbumr@celestica.com]

@mudsut4ke mudsut4ke changed the title Master dx010 xcvrd event support [device/celestica]: Add xcvrd event support for Seastone-DX010 Nov 11, 2020
@lguohan
Copy link
Collaborator

lguohan commented Nov 11, 2020

can you verify if xrcvd is running ok or not?

@mudsut4ke
Copy link
Contributor Author

can you verify if xrcvd is running ok or not?

@lguohan, I compiling a test image
After verified , I will mark this PR to ready to review

@lguohan
Copy link
Collaborator

lguohan commented Nov 11, 2020

retest broadcom please

jleveque
jleveque previously approved these changes Nov 11, 2020
@mudsut4ke
Copy link
Contributor Author

retest broadcom please

@lguohan
Copy link
Collaborator

lguohan commented Nov 13, 2020

is this tested?

@mudsut4ke
Copy link
Contributor Author

is this tested?

@lguohan , I found this error on xcvrd

Screenshot from 2020-11-13 11-28-56

It cause by missing mapping of logical port names to ASIC instance on device that used platform.json
So, I submit another PR to fix it : sonic-net/sonic-platform-common#141

@mudsut4ke mudsut4ke marked this pull request as ready for review November 13, 2020 05:09
@lguohan
Copy link
Collaborator

lguohan commented Nov 26, 2020

@mudsut4ke, now the sonic-net/sonic-platform-common#141 has been merge. can you resolve the conflict for this pr?

@mudsut4ke
Copy link
Contributor Author

@mudsut4ke, now the Azure/sonic-platform-common#141 has been merge. can you resolve the conflict for this pr?

@lguohan , those file are conflict because of this change #5926
So, After resolved the conflict I will re-verify an image again

@lgtm-com
Copy link

lgtm-com bot commented Nov 27, 2020

This pull request introduces 1 alert when merging 5e2a506 into 7f21c0b - view on LGTM.com

new alerts:

  • 1 for Unused import

@lguohan
Copy link
Collaborator

lguohan commented Dec 13, 2020

retest baseimage please

@jleveque jleveque merged commit 4257c79 into sonic-net:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Celestica] PMon error
3 participants