Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPB] [Mellanox] added capability files for SN2410 platform #6017

Merged

Conversation

vadymhlushko-mlnx
Copy link
Contributor

@vadymhlushko-mlnx vadymhlushko-mlnx commented Nov 24, 2020

- Why I did it

platform.json and hwsku.json files are required for a feature called Dynamic Port Breakout

- How I did it

Created capability files according to platform specification SN2410

- How to verify it

Full qualification requires bugs fixes reported under sonic-buildimage

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
Copy link
Collaborator

@liat-grozovik liat-grozovik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interfaces with 1 lane should not be split
interfaces with 4 lanes can be split to 4 but then consecutive port should be removed.

@jleveque
Copy link
Contributor

jleveque commented Dec 1, 2020

Retest broadcom please

@jleveque
Copy link
Contributor

jleveque commented Dec 1, 2020

Retest vsimage please

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
Copy link
Collaborator

@liat-grozovik liat-grozovik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Current implementation of SONiC DPB is not aligned with the HLD and is missing functionality required for SN2410 split to 4 (unable to remove consecutive port ) this option should be removed with a comment in the file.

  2. Add additional speed options to supported speeds.

…4, because current implementation of DPB doesn't support disabling of consecutive port

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Copy link
Contributor Author

Please don't merge this PR until [DPB][MLNX][YANG-models] extended regex pattern according to MLNX systems speeds requirements PR will be merged

@vadymhlushko-mlnx vadymhlushko-mlnx marked this pull request as ready for review December 28, 2020 17:29
@liat-grozovik liat-grozovik changed the title [DPB] added capability files for SN2410 platform [DPB] [Mellanox] added capability files for SN2410 platform Jan 13, 2021
@liat-grozovik liat-grozovik merged commit 553ece0 into sonic-net:master Jan 17, 2021
@vadymhlushko-mlnx vadymhlushko-mlnx deleted the sn2410_dpb_capability_files branch January 25, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants