Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sonic-platform-common] Update submodule #6041

Merged
merged 2 commits into from
Nov 26, 2020
Merged

[sonic-platform-common] Update submodule #6041

merged 2 commits into from
Nov 26, 2020

Conversation

jleveque
Copy link
Contributor

@jleveque jleveque commented Nov 25, 2020 •
edited
Loading

Commits include:

@jleveque jleveque self-assigned this Nov 25, 2020
lguohan
lguohan previously approved these changes Nov 26, 2020
View reviewed changes
@judyjoseph
Copy link
Contributor

@jleveque Could you take this PR as well ..sonic-net/sonic-platform-common#141, or let me know I can update this PR itself - thanks

@jleveque
Copy link
Contributor Author

jleveque commented Nov 26, 2020 •
edited
Loading

@jleveque Could you take this PR as well ..Azure/sonic-platform-common#141, or let me know I can update this PR itself - thanks

@judyjoseph: vsimage test failed, so I pulled in your commit, seeing as I had to wait for a re-test anyway.

@lguohan
Copy link
Collaborator

lguohan commented Nov 26, 2020

retest vs please

@lguohan
Copy link
Collaborator

lguohan commented Nov 26, 2020

retest mellanox please

@lguohan
Copy link
Collaborator

lguohan commented Nov 26, 2020

retest vsimage please

@lguohan lguohan merged commit 00d3cb7 into sonic-net:master Nov 26, 2020
@jleveque jleveque deleted the update_plat_common branch November 26, 2020 21:35
@judyjoseph
Copy link
Contributor

@jleveque Could you take this PR as well ..Azure/sonic-platform-common#141, or let me know I can update this PR itself - thanks

@judyjoseph: vsimage test failed, so I pulled in your commit, seeing as I had to wait for a re-test anyway.

Thanks @jleveque .. wanted to get this PR in as it will unblock for single ASIC platforms using platform.json file.

santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
@jleveque @santhosh-kt
[sonic-platform-common] Update submodule (sonic-net#6041)
b4d541e 
Commits include:

* src/sonic-platform-common d912db6...fa0aaa6 (3):
  > [sonic_sfp]: add logical_to_asic dict (sonic-net#141)
  > [sonic_pcie][sonic_ssd] Make Python 3-compliant (sonic-net#150)
  > [eeprom_base] Close lock file after unlocking (sonic-net#149)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

@judyjoseph judyjoseph Awaiting requested review from judyjoseph

Assignees

@jleveque jleveque

Labels
Submodule Update ⏫
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jleveque @judyjoseph @lguohan