Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lldp docker to use python3 version of sonic-db-syncd package. #6046

Merged
merged 5 commits into from
Nov 30, 2020

Conversation

abdosi
Copy link
Contributor

@abdosi abdosi commented Nov 26, 2020

What I did:

  • Made changes so that Lldp docker start using py3 of sonic-db-syncd

  • submodule update sonic-db-syncd

5cc29a1b32d8d1f4dfbc967bfea2727c50a49c76 (HEAD -> master, origin/master, origin/HEAD) Changes to convert sonic-dbsyncd from python 2 to 3

How I verify:

Verify and tested local build.

Changes to convert sonic-dbsyncd from python 2 to 3
Also makde lldp docker to python3 sonic-dbsyncd package.

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Copy link
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need to list the Python 2 swsscommon package (PYTHON_SWSSCOMMON) as a dependency in rules/docker-lldp.mk?

@abdosi
Copy link
Contributor Author

abdosi commented Nov 26, 2020

Do we still need to list the Python 2 swsscommon package (PYTHON_SWSSCOMMON) as a dependency in rules/docker-lldp.mk?

@jleveque No we don't need it and i wanted to remove it but saw other modules still having it even though move to python 3 so i thought there might be reason for that.

@jleveque
Copy link
Contributor

Do we still need to list the Python 2 swsscommon package (PYTHON_SWSSCOMMON) as a dependency in rules/docker-lldp.mk?

@jleveque No we don't need it and i wanted to remove it but saw other modules still having it even though move to python 3 so i thought there might be reason for that.

If you're positive nothing else in the container needs it, you can remove it. We need to make a pass later and clean up other places where Python 2 packages no longer need to be installed.

@lguohan
Copy link
Collaborator

lguohan commented Nov 26, 2020

please resubmit the pr. the commit is no longer available.

@lguohan
Copy link
Collaborator

lguohan commented Nov 26, 2020

retest this please

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
@abdosi
Copy link
Contributor Author

abdosi commented Nov 27, 2020

retest vsimage please

@abdosi
Copy link
Contributor Author

abdosi commented Nov 27, 2020

Do we still need to list the Python 2 swsscommon package (PYTHON_SWSSCOMMON) as a dependency in rules/docker-lldp.mk?

@jleveque No we don't need it and i wanted to remove it but saw other modules still having it even though move to python 3 so i thought there might be reason for that.

If you're positive nothing else in the container needs it, you can remove it. We need to make a pass later and clean up other places where Python 2 packages no longer need to be installed.

@jleveque updated to remove python2 swsscommon

@abdosi
Copy link
Contributor Author

abdosi commented Nov 27, 2020

Retest vsimage please

@lguohan lguohan merged commit 872c85d into sonic-net:master Nov 30, 2020
abdosi added a commit that referenced this pull request Feb 6, 2021
* Remove makefile and 
As part of #6046 we have moved to python3 of dbsyncd.
Cleanup the python2 makefile and dependency.
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>

* Revert "Remove makefile and dependency for python2 of dbsyncd."

This reverts commit ceaa4f8.

* Fix

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
lguohan pushed a commit that referenced this pull request Feb 7, 2021
* Remove makefile and 
As part of #6046 we have moved to python3 of dbsyncd.
Cleanup the python2 makefile and dependency.
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>

* Revert "Remove makefile and dependency for python2 of dbsyncd."

This reverts commit ceaa4f8.

* Fix

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
…sonic-net#6046)

Made changes so that Lldp docker start using py3 of sonic-db-syncd

submodule update sonic-db-syncd
5cc29a1b32d8d1f4dfbc967bfea2727c50a49c76 (HEAD -> master, origin/master, origin/HEAD) Changes to convert sonic-dbsyncd from python 2 to 3

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants